Re: Review Request 31479: Add missing deletes in stout

2015-03-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31479/#review76252 --- Tim, is this still relevant? - Niklas Nielsen On Feb. 26, 2015, 2

Re: Review Request 31479: Add missing deletes in stout

2015-02-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31479/#review74404 --- Duplicate detected: https://reviews.apache.org/r/31494/ - Alexander

Re: Review Request 31479: Add missing deletes in stout

2015-02-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31479/ --- (Updated Feb. 26, 2015, 10:08 p.m.) Review request for mesos. Repository: mes

Re: Review Request 31479: Add missing deletes in stout

2015-02-26 Thread Timothy Chen
> On Feb. 26, 2015, 5:54 p.m., Dominic Hamon wrote: > > I replaced the buffers with vectors to avoid deletes here: > > https://reviews.apache.org/r/31489/ > > Timothy Chen wrote: > Sounds good, I'll discard this. > > Ben Mahler wrote: > I just noticed this patch, why did we decide to t

Re: Review Request 31479: Add missing deletes in stout

2015-02-26 Thread Ben Mahler
> On Feb. 26, 2015, 5:54 p.m., Dominic Hamon wrote: > > I replaced the buffers with vectors to avoid deletes here: > > https://reviews.apache.org/r/31489/ > > Timothy Chen wrote: > Sounds good, I'll discard this. I just noticed this patch, why did we decide to throw away the fix that most

Re: Review Request 31479: Add missing deletes in stout

2015-02-26 Thread Timothy Chen
> On Feb. 26, 2015, 5:54 p.m., Dominic Hamon wrote: > > I replaced the buffers with vectors to avoid deletes here: > > https://reviews.apache.org/r/31489/ Sounds good, I'll discard this. - Timothy --- This is an automatically generated

Re: Review Request 31479: Add missing deletes in stout

2015-02-26 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31479/#review74295 --- I replaced the buffers with vectors to avoid deletes here: https://

Re: Review Request 31479: Add missing deletes in stout

2015-02-26 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31479/#review74294 --- Ship it! Ship It! - Ian Downes On Feb. 26, 2015, 1:10 a.m., Timo

Re: Review Request 31479: Add missing deletes in stout

2015-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31479/#review74249 --- Patch looks great! Reviews applied: [31479] All tests passed. - M

Review Request 31479: Add missing deletes in stout

2015-02-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31479/ --- Review request for mesos. Repository: mesos Description --- Add missing