Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

> On March 3, 2015, 1:08 a.m., Chi Zhang wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 127 > > > > > > Is it the case that the smaller the number, the higher the priority? If > > that's t

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

> On March 3, 2015, 1:08 a.m., Chi Zhang wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 139 > > > > > > isn't it more like a CONTAINER_FLOWID_BEGIN? I rename it to CONTAINER_MIN_FLOWID.

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

> On March 3, 2015, 1:08 a.m., Chi Zhang wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1873 > > > > > > Any specific reason host traffic has the lowest prioity among these 3? Yes, to ens

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review74859 --- Cong, while you are working on the recovery story: there is a caveat

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review74838 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

> On Feb. 26, 2015, 11:31 p.m., Dominic Hamon wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1619 > > > > > > is there no better way to do this than loop over the entire set and > > check

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

> On Feb. 26, 2015, 11:31 p.m., Dominic Hamon wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 2500 > > > > > > metric for tracking removal errors? Oh, here I want to remove the egress qdis

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review74772 --- Patch looks great! Reviews applied: [31502, 31503, 31504, 31505] A

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

> On Feb. 26, 2015, 11:31 p.m., Dominic Hamon wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 1829 > > > > > > any tests for this? Yes, the test case in the previous patch should have a te

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

> On Feb. 27, 2015, 7:50 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1828-1847 > > > > > > I'm confused - do these need to be configured for each container? I > > tho

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated March 2, 2015, 5:21 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review74609 --- Bad patch! Reviews applied: [31502, 31502] Failed command: ./suppo

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated Feb. 27, 2015, 9:40 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review74457 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review74423 --- Patch looks great! Reviews applied: [31505] All tests passed. - M

Re: Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review74396 --- add a jira reference and any dependencies please. src/slave/contai

Review Request 31505: (4/4) Add flow classifiers for fq_codel on egress

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Repository: mesos