Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-15 Thread Alexander Rukletsov
> On April 8, 2015, 8:16 p.m., Jie Yu wrote: > > src/common/resources.cpp, lines 450-459 > > > > > > The semantics of this function becomes a little weired now. For > > example, for a resource that has `role == "*"` a

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/#review79410 --- src/common/resources.cpp

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/ --- (Updated April 7, 2015, 9:56 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-25 Thread Alexander Rukletsov
> On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 44-49 > > > > > > Why these operatos (also those that were here before) are defined here > > and not in `include/mesos/typ

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-25 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/#review77752 --- include/mesos/resources.hpp

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/ --- (Updated March 20, 2015, 10:36 p.m.) Review request for mesos, Alexander Ruklet

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-18 Thread Jie Yu
> On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 44-49 > > > > > > Why these operatos (also those that were here before) are defined here > > and not in `include/mesos/typ

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-18 Thread Michael Park
> On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 69-74 > > > > > > Not yours, but resently, Vinod did a cleanup in equivalence operators > > for our proto messages in `typ

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-18 Thread Michael Park
> On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 44-49 > > > > > > Why these operatos (also those that were here before) are defined here > > and not in `include/mesos/typ

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/ --- (Updated March 18, 2015, 7:44 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/ --- (Updated March 18, 2015, 5:25 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-17 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/#review76752 --- src/common/resources.cpp

Re: Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/ --- (Updated March 17, 2015, 4:06 a.m.) Review request for mesos, Alexander Ruklets

Review Request 32140: Enable 'Resources' to handle 'Resource::ReservationInfo'.

2015-03-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, and Jie Yu. Bugs: ME