Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/#review81143 --- src/common/resources.cpp

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-22 Thread Alexander Rukletsov
> On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 69-74 > > > > > > Not yours, but resently, Vinod did a cleanup in equivalence operators > > for our proto messages in `typ

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-21 Thread Michael Park
> On March 25, 2015, 5:07 p.m., Timothy Chen wrote: > > include/mesos/resources.hpp, line 182 > > > > > > I'm not sure the following comment adds any value? > > > > "If the optional ReservationInfo is given, t

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-21 Thread Michael Park
> On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, lines 69-74 > > > > > > Not yours, but resently, Vinod did a cleanup in equivalence operators > > for our proto messages in `typ

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/#review80201 --- src/common/resources.cpp

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-15 Thread Alexander Rukletsov
> On April 8, 2015, 8:16 p.m., Jie Yu wrote: > > src/common/resources.cpp, lines 450-459 > > > > > > The semantics of this function becomes a little weired now. For > > example, for a resource that has `role == "*"` a

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-15 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32140/ --- (Updated April 15, 2015, 4:12 p.m.) Review request for mesos, Alexander Ruklets