Re: Review Request 32463: Improved testing around state.json endpoints.

2015-04-09 Thread Ben Mahler
On March 25, 2015, 5:38 p.m., Alexander Rukletsov wrote: src/tests/master_tests.cpp, line 2816 https://reviews.apache.org/r/32463/diff/1/?file=904857#file904857line2816 Why do you check the type here, but not above for e.g. `DATE`, `TIME`, and `USER`? Ah nice catch, `id` needs

Re: Review Request 32463: Improved testing around state.json endpoints.

2015-03-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32463/#review77933 --- Ship it! lgtm modulo alex's comments. - Vinod Kone On March 24,

Re: Review Request 32463: Improved testing around state.json endpoints.

2015-03-25 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32463/#review77738 --- src/tests/master_tests.cpp