Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-04-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/ --- (Updated April 20, 2015, 7:58 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-04-20 Thread Vinod Kone
> On April 8, 2015, 6:38 p.m., Isabel Jimenez wrote: > > src/scheduler/scheduler.cpp, line 239 > > > > > > Don't we also need to add a TODO in sched.cpp for this to be remove? The TODO in mesos.proto should be enough

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-04-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/#review79392 --- src/scheduler/scheduler.cpp

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/#review79354 --- Ship it! - Alexander Rukletsov On March 31, 2015, 12:06 a.m., Vin

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-03-30 Thread Vinod Kone
> On March 26, 2015, 1:32 a.m., Ben Mahler wrote: > > Should you be adding a TODO on 'Request' to remove it when the old driver > > goes away? Or is there a reason to leave it indefinitely? > > Vinod Kone wrote: > Added TODOs in master.hpp and mesos.proto. Thanks. NNFR. - Vinod ---

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-03-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/ --- (Updated March 31, 2015, 12:06 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-03-30 Thread Vinod Kone
> On March 26, 2015, 1:32 a.m., Ben Mahler wrote: > > Should you be adding a TODO on 'Request' to remove it when the old driver > > goes away? Or is there a reason to leave it indefinitely? Added TODOs in master.hpp and mesos.proto. Thanks. - Vinod --

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-03-27 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/#review78030 --- Ship it! Ship It! - Alexander Rojas On March 26, 2015, 12:07 a.m

Re: Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-03-25 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/#review77842 --- Ship it! Should you be adding a TODO on 'Request' to remove it when

Review Request 32501: Removed REQUEST call from scheduler.proto.

2015-03-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32501/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1127 https://issues.ap