Re: Review Request 32843: Updated KILL to include SlaveID.

2015-04-21 Thread Vinod Kone
On April 20, 2015, 10:46 p.m., Ben Mahler wrote: src/master/master.cpp, line 2736 https://reviews.apache.org/r/32843/diff/2/?file=936875#file936875line2736 It looks like we can do this without having the extra `killTask` method: just have this convert to the `Kill` `Call` and

Re: Review Request 32843: Updated KILL to include SlaveID.

2015-04-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32843/ --- (Updated April 21, 2015, 10:57 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32843: Updated KILL to include SlaveID.

2015-04-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32843/#review80990 --- Ship it! Modulo Ben's comments. - Alexander Rukletsov On April

Re: Review Request 32843: Updated KILL to include SlaveID.

2015-04-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32843/ --- (Updated April 20, 2015, 8:02 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 32843: Updated KILL to include SlaveID.

2015-04-20 Thread Vinod Kone
On April 8, 2015, 5:52 p.m., Alexander Rukletsov wrote: I'm still not sure whether it's necessary to provide `SlaveID` in the kill request. But I'd better comment on MESOS-1127 instead. made SlaveID optional like we did for Reconcile for backwards compatibility. - Vinod

Re: Review Request 32843: Updated KILL to include SlaveID.

2015-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32843/#review79373 --- I'm still not sure whether it's necessary to provide `SlaveID` in

Review Request 32843: Updated KILL to include SlaveID.

2015-04-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32843/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1127