Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review81087 --- Patch looks great! Reviews applied: [33241] All tests passed. - M

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-21 Thread Ricardo Cervera-Navarro
> On April 21, 2015, 10:03 a.m., Joe Smith wrote: > > docs/metrics.md, line 227 > > > > > > hm.. offhand I don't recall what this means, but we should get a > > definition here Unless somebody knows what this is, I'm

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-21 Thread Ricardo Cervera-Navarro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/ --- (Updated April 21, 2015, 3:09 p.m.) Review request for mesos. Changes ---

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-21 Thread Dave Lester
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review81050 --- High-level comment, this looks good. Ideally, we would be using mark

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-21 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review80995 --- docs/metrics.md

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review80274 --- Patch looks great! Reviews applied: [33241] All tests passed. - M

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-15 Thread Ricardo Cervera-Navarro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/ --- (Updated April 15, 2015, 2:49 p.m.) Review request for mesos. Changes ---

Re: Review Request 33241: docs: Add documentation on observability metrics.

2015-04-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/#review80268 --- Bad patch! Reviews applied: [33241] Failed command: ./support/appl

Review Request 33241: docs: Add documentation on observability metrics.

2015-04-15 Thread Ricardo Cervera-Navarro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33241/ --- Review request for mesos. Bugs: MESOS-2621 https://issues.apache.org/jira/b