Re: executor source not set

2015-03-16 Thread James DeFelice
filed https://issues.apache.org/jira/browse/MESOS-2499 to track this On Sun, Mar 15, 2015 at 11:20 PM, Vinod Kone wrote: > Ah crap. You are right! Please file a JIRA. We should have a test for this. > > On Sun, Mar 15, 2015 at 8:05 PM, James DeFelice > wrote: > > > Vinod, I suspect that the "st

Re: executor source not set

2015-03-15 Thread Vinod Kone
Ah crap. You are right! Please file a JIRA. We should have a test for this. On Sun, Mar 15, 2015 at 8:05 PM, James DeFelice wrote: > Vinod, I suspect that the "status.set_source" is meaningless since it's > likely updating an object that's a copy of what's actually inside the > StatusUpdate that

Re: executor source not set

2015-03-15 Thread James DeFelice
Vinod, I suspect that the "status.set_source" is meaningless since it's likely updating an object that's a copy of what's actually inside the StatusUpdate that's forward()ed from the slave. In the master code, I see references to things like "message.mutable_update().mutable_status()" that seem obt

Re: executor source not set

2015-03-15 Thread James DeFelice
Yes, generated by the executor. I do see a source for status updates generated by reconciliation processes. For example: reason="REASON_RECONCILIATION",source="SOURCE_MASTER",state="TASK_RUNNING" But for status updates generated by my executor, the scheduler sees this: reason="none",source="non

Re: executor source not set

2015-03-15 Thread Vinod Kone
Are these updates generated by the executor? Note that updates *generated* by slave or master will have a different source. Are you not seeing any source at all in the updates? On Sun, Mar 15, 2015 at 6:59 PM, James DeFelice wrote: > Thanks, I found the same. For some reason I'm not seeing a Sou

Re: executor source not set

2015-03-15 Thread James DeFelice
Thanks, I found the same. For some reason I'm not seeing a Source set in the updates that the scheduler is receiving. The updates are being generated via the mesos-go bindings. The bindings shouldn't matter since the slave is supposed to fill in the blank. Not sure what's going on, needs more inves

Re: executor source not set

2015-03-15 Thread Vinod Kone
It is enforced by the slave to be future proof (a future where there will be no executor driver). https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L2491 On Sun, Mar 15, 2015 at 11:45 AM, James DeFelice wrote: > Is there a reason that the native executor driver bindings don't chec

executor source not set

2015-03-15 Thread James DeFelice
Is there a reason that the native executor driver bindings don't check for/enforce a TaskStatus.Source of SOURCE_EXECUTOR? https://github.com/apache/mesos/blob/master/src/exec/exec.cpp#L490 Or is that supposed to be handled somewhere else? -James