[GitHub] metamodel pull request: Fresh PR for Sor

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/19#discussion_r29112631 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,403 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] metamodel pull request: Fresh PR for Sor

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/19#discussion_r29112578 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,403 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] metamodel pull request: Fresh PR for Sor

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/19#discussion_r29112571 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,403 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] metamodel pull request: Fresh PR for Sor

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/19#discussion_r29112568 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,403 @@ +/** + * Licensed to the Apache Software Fo

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/16#issuecomment-96419179 For the future: You don't need to close the Pull Requests just because you have changes. The moment you commit new code to the branch then the existing PR is aut

[GitHub] metamodel pull request: Fresh PR for Sor

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/19#discussion_r29112490 --- Diff: solr/src/test/java/org/apache/metamodel/solr/SolrDataContextTest1.java --- @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache Softwa

[GitHub] metamodel pull request: Fresh PR for Sor

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/19#discussion_r29112462 --- Diff: solr/src/test/java/org/apache/metamodel/solr/SolrDataContextTest1.java --- @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache Softwa

[GitHub] metamodel pull request: Fresh PR for Sor

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/19#discussion_r29112457 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataSet.java --- @@ -0,0 +1,174 @@ +/** + * Licensed to the Apache Software Foundat

[jira] [Commented] (METAMODEL-135) SQL parsing fails when 'AND' or 'OR' keywords are in caps

[ https://issues.apache.org/jira/browse/METAMODEL-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513176#comment-14513176 ] Kasper Sørensen commented on METAMODEL-135: --- Oh and If you want the filter it

[jira] [Closed] (METAMODEL-135) SQL parsing fails when 'AND' or 'OR' keywords are in caps

[ https://issues.apache.org/jira/browse/METAMODEL-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kasper Sørensen closed METAMODEL-135. - Resolution: Not A Problem > SQL parsing fails when 'AND' or 'OR' keywords are in caps >

[jira] [Commented] (METAMODEL-135) SQL parsing fails when 'AND' or 'OR' keywords are in caps

[ https://issues.apache.org/jira/browse/METAMODEL-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513173#comment-14513173 ] Kasper Sørensen commented on METAMODEL-135: --- This is actually not a bug, but

[jira] [Created] (METAMODEL-135) SQL parsing fails when 'AND' or 'OR' keywords are in caps

Ashish Mukherjee created METAMODEL-135: -- Summary: SQL parsing fails when 'AND' or 'OR' keywords are in caps Key: METAMODEL-135 URL: https://issues.apache.org/jira/browse/METAMODEL-135 Project: Apa

[GitHub] metamodel pull request: Fresh PR for Sor

GitHub user ashish-m-yh opened a pull request: https://github.com/apache/metamodel/pull/19 Fresh PR for Sor You can merge this pull request into a Git repository by running: $ git pull https://github.com/ashish-m-yh/metamodel master Alternatively you can review and apply thes

[GitHub] metamodel pull request: Solr connector additions

Github user ashish-m-yh commented on the pull request: https://github.com/apache/metamodel/pull/18#issuecomment-96411832 Trying to fix the CI failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] metamodel pull request: Solr connector additions

Github user ashish-m-yh closed the pull request at: https://github.com/apache/metamodel/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] metamodel pull request: Solr connector additions

Github user ashish-m-yh commented on the pull request: https://github.com/apache/metamodel/pull/18#issuecomment-96411467 I am not sure why the build failed on the CI server, since it builds fine on my dev. environment. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (METAMODEL-129) Implement Solr Data Connector

[ https://issues.apache.org/jira/browse/METAMODEL-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513146#comment-14513146 ] Ashish Mukherjee commented on METAMODEL-129: https://github.com/apache/meta

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user ashish-m-yh commented on a diff in the pull request: https://github.com/apache/metamodel/pull/16#discussion_r29111710 --- Diff: solr/src/test/java/org/apache/metamodel/solr/SolrDataContextTest1.java --- @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache Software

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user ashish-m-yh commented on a diff in the pull request: https://github.com/apache/metamodel/pull/16#discussion_r29111668 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,429 @@ +/** + * Licensed to the Apache Software Found

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user ashish-m-yh commented on a diff in the pull request: https://github.com/apache/metamodel/pull/16#discussion_r29111653 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,429 @@ +/** + * Licensed to the Apache Software Found

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user ashish-m-yh commented on a diff in the pull request: https://github.com/apache/metamodel/pull/16#discussion_r29111641 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,429 @@ +/** + * Licensed to the Apache Software Found

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user ashish-m-yh commented on a diff in the pull request: https://github.com/apache/metamodel/pull/16#discussion_r29111638 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,429 @@ +/** + * Licensed to the Apache Software Found

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user ashish-m-yh commented on a diff in the pull request: https://github.com/apache/metamodel/pull/16#discussion_r29111634 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,429 @@ +/** + * Licensed to the Apache Software Found

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user ashish-m-yh commented on a diff in the pull request: https://github.com/apache/metamodel/pull/16#discussion_r29111614 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,429 @@ +/** + * Licensed to the Apache Software Found

[GitHub] metamodel pull request: Solr connector additions

GitHub user ashish-m-yh opened a pull request: https://github.com/apache/metamodel/pull/18 Solr connector additions Have removed all the IDE files, fixed indentation too. Rest of the comments are responded to against the earlier PR comments. You can merge this pull request

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user ashish-m-yh commented on a diff in the pull request: https://github.com/apache/metamodel/pull/16#discussion_r29111608 --- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java --- @@ -0,0 +1,429 @@ +/** + * Licensed to the Apache Software Found

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user ashish-m-yh commented on the pull request: https://github.com/apache/metamodel/pull/16#issuecomment-96409034 I am closing this and creating a new pull request with responses to all the review comments. --- If your project is set up for it, you can reply to this email and

[GitHub] metamodel pull request: Solr connector added to existing DataConte...

Github user ashish-m-yh closed the pull request at: https://github.com/apache/metamodel/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature