[jira] [Commented] (METAMODEL-218) Mapping of STRING and NUMBER data types in JDBC module's CREATE TABLE support not working

2015-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METAMODEL-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045066#comment-15045066 ] ASF GitHub Bot commented on METAMODEL-218: -- GitHub user kaspersorensen opened

[GitHub] metamodel pull request: METAMODEL-218: Fixed

2015-12-07 Thread kaspersorensen
GitHub user kaspersorensen opened a pull request: https://github.com/apache/metamodel/pull/76 METAMODEL-218: Fixed This fixes METAMODEL-218 by adding a few return statement in DefaultQueryRewriter. Also updated the test template to ensure that it's working on all the datab

[jira] [Created] (METAMODEL-218) Mapping of STRING and NUMBER data types in JDBC module's CREATE TABLE support not working

2015-12-07 Thread JIRA
Kasper Sørensen created METAMODEL-218: - Summary: Mapping of STRING and NUMBER data types in JDBC module's CREATE TABLE support not working Key: METAMODEL-218 URL: https://issues.apache.org/jira/browse/METAMODE

[jira] [Created] (METAMODEL-217) Add fallback strategy in JDBC module for queries that are not rewriteable

2015-12-07 Thread JIRA
Kasper Sørensen created METAMODEL-217: - Summary: Add fallback strategy in JDBC module for queries that are not rewriteable Key: METAMODEL-217 URL: https://issues.apache.org/jira/browse/METAMODEL-217

[jira] [Commented] (METAMODEL-195) Scalar function to get key from a MAP type field

2015-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METAMODEL-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044958#comment-15044958 ] ASF GitHub Bot commented on METAMODEL-195: -- Github user kaspersorensen comment

[jira] [Resolved] (METAMODEL-216) Added new aggregate functions FIRST, LAST, RANDOM

2015-12-07 Thread JIRA
[ https://issues.apache.org/jira/browse/METAMODEL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kasper Sørensen resolved METAMODEL-216. --- Resolution: Fixed > Added new aggregate functions FIRST, LAST, RANDOM > ---

[GitHub] metamodel pull request: METAMODEL-195 - a MAP_VALUE function

2015-12-07 Thread kaspersorensen
Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/70#issuecomment-162528258 What do you think about merging this @albertostratio? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] metamodel pull request: Added new aggregate functions FIRST, LAST,...

2015-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metamodel/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[jira] [Created] (METAMODEL-216) Added new aggregate functions FIRST, LAST, RANDOM

2015-12-07 Thread JIRA
Kasper Sørensen created METAMODEL-216: - Summary: Added new aggregate functions FIRST, LAST, RANDOM Key: METAMODEL-216 URL: https://issues.apache.org/jira/browse/METAMODEL-216 Project: Apache MetaMo

[jira] [Resolved] (METAMODEL-215) Make NumberComparator better handle specialized number types like Long, Integer, BigDecimal

2015-12-07 Thread JIRA
[ https://issues.apache.org/jira/browse/METAMODEL-215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kasper Sørensen resolved METAMODEL-215. --- Resolution: Fixed Fix Version/s: 4.4.2 > Make NumberComparator better handle

[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...

2015-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metamodel/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[jira] [Created] (METAMODEL-215) Make NumberComparator better handle specialized number types like Long, Integer, BigDecimal

2015-12-07 Thread JIRA
Kasper Sørensen created METAMODEL-215: - Summary: Make NumberComparator better handle specialized number types like Long, Integer, BigDecimal Key: METAMODEL-215 URL: https://issues.apache.org/jira/browse/METAMO

[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...

2015-12-07 Thread LosD
Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/75#issuecomment-162521315 Yeah. That @losd guy started panicking, but I calmed him down :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...

2015-12-07 Thread kaspersorensen
Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/75#issuecomment-162520686 Glad that you sorted it out ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...

2015-12-07 Thread LosD
Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/75#issuecomment-162518223 Let's go with the LGTM :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...

2015-12-07 Thread LosD
Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/75#issuecomment-162518104 Okay, it probably doesn't matter. It doesn't seem to be used for (SQL) equals unless there's a need to parse it anyway. --- If your project is set up for it, you can rep

[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...

2015-12-07 Thread LosD
Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/75#issuecomment-162516676 I realize we are for much more than SQL, but the null comparisons being equal worries me a bit, "NULL is never equal to anything" is a pretty important part of SQL (and

[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...

2015-12-07 Thread LosD
Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/75#issuecomment-162511561 Ugh, huge reformatting. But fair, most of the file was changed anyway, and it had the wrong indentation character before (and the secret 'add ?w=1 to URL' Github trick sa

[GitHub] metamodel pull request: Hardened the NumberComparator to have bett...

2015-12-07 Thread kaspersorensen
GitHub user kaspersorensen opened a pull request: https://github.com/apache/metamodel/pull/75 Hardened the NumberComparator to have better support for number types. (Sorry for the code reformatting, but the old was clearly wrong - used tabs instead of spaces) You can merge this