[GitHub] metamodel pull request: ElasticSearch bulk support and mapping cre...

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/98#discussion_r61196721 --- Diff: elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java --- @@ -95,17 +103,49 @@ public stati

[GitHub] metamodel pull request: ElasticSearch bulk support and mapping cre...

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/98#discussion_r61195959 --- Diff: elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java --- @@ -78,15 +86,15 @@ public static

[GitHub] metamodel pull request: ElasticSearch bulk support and mapping cre...

Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/98#issuecomment-214892259 Code looks good to me, though there was a few surprises. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] metamodel pull request: ElasticSearch bulk support and mapping cre...

Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/98#discussion_r61166829 --- Diff: elasticsearch/native/src/main/java/org/apache/metamodel/elasticsearch/nativeclient/ElasticSearchCreateTableBuilder.java --- @@ -44,15 +44,20 @@ publ

[GitHub] metamodel pull request: ElasticSearch bulk support and mapping cre...

Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/98#discussion_r61166439 --- Diff: elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java --- @@ -78,15 +86,15 @@ public static QueryBuil

[GitHub] metamodel pull request: ElasticSearch bulk support and mapping cre...

Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/98#discussion_r61165997 --- Diff: elasticsearch/rest/pom.xml --- @@ -27,7 +27,7 @@ under the License. 4.0.0 - 0.1.7 + 2.0.2 --- E

[GitHub] metamodel pull request: ElasticSearch bulk support and mapping cre...

Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/98#discussion_r61165846 --- Diff: elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java --- @@ -95,17 +103,49 @@ public static QueryBui

[GitHub] metamodel pull request: Feature/read fixedwidth metadata files

Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/97#issuecomment-214888016 Single very, very minor thing. Merge if you don't care :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] metamodel pull request: Feature/read fixedwidth metadata files

Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/97#discussion_r61158626 --- Diff: core/src/main/java/org/apache/metamodel/schema/naming/CustomColumnNamingStrategy.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache S

[GitHub] metamodel pull request: Feature/read fixedwidth metadata files

Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/97#issuecomment-214867537 Should be ready for re-review now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Resolved] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kasper Sørensen resolved METAMODEL-244. --- Resolution: Fixed Fix Version/s: 4.5.3 > Ability to specify column names for

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258783#comment-15258783 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user asfgit closed the pull

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258785#comment-15258785 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user LosD commented on the

[GitHub] metamodel pull request: METAMODEL-244

Github user asfgit closed the pull request at: https://github.com/apache/metamodel/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] metamodel pull request: METAMODEL-244

Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/96#issuecomment-214864543 Yep. A bit "dangerous" to still get it with `ColumnNamingStrategies.defaultStrategy()`, but nevermind. :) --- If your project is set up for it, you can reply to this em

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258775#comment-15258775 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user kaspersorensen comment

[GitHub] metamodel pull request: METAMODEL-244

Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/96#issuecomment-214863231 Renamed it. Will merge it now then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] metamodel pull request: METAMODEL-244

Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/96#issuecomment-214856085 Looks good! Maybe I'd let the test be DelegatingIntrinsicSwitchColumnNamingStrategyTest. That it is the default is maybe less relevant for the test than what it really is

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258730#comment-15258730 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user LosD commented on the

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258719#comment-15258719 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user kaspersorensen comment

[GitHub] metamodel pull request: METAMODEL-244

Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/96#issuecomment-214852899 Changed as per review remarks. What do you think now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (METAMODEL-246) Strip illegal characters in fields of ElasticSearch document type creation

[ https://issues.apache.org/jira/browse/METAMODEL-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258281#comment-15258281 ] ASF GitHub Bot commented on METAMODEL-246: -- Github user kaspersorensen comment

[GitHub] metamodel pull request: ElasticSearch bulk support and mapping cre...

Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/98#issuecomment-214782257 Correction: It's actually also a third thing that is added, namely stripping of illegal field name characters, see METAMODEL-246 --- If your project i

[GitHub] metamodel pull request: ElasticSearch bulk support and mapping cre...

GitHub user kaspersorensen opened a pull request: https://github.com/apache/metamodel/pull/98 ElasticSearch bulk support and mapping creation using Map This branch adds support for two things... * Creation of elastic search mappings (document types) using a JSON object in

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258184#comment-15258184 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user kaspersorensen comment

[GitHub] metamodel pull request: METAMODEL-244

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/96#discussion_r61097276 --- Diff: core/src/main/java/org/apache/metamodel/schema/naming/DefaultColumnNamingStrategy.java --- @@ -0,0 +1,35 @@ +/** + * Licensed to t

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258181#comment-15258181 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user kaspersorensen comment

[GitHub] metamodel pull request: METAMODEL-244

Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/96#discussion_r61096874 --- Diff: core/src/main/java/org/apache/metamodel/schema/naming/UniqueColumnNamingStrategy.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to th

RE: Approach to submitting ElasticSearch mapping

Ok I have patch to turn it into a map instead. Will post a PR a bit later then. Den 26. apr. 2016 12.15 AM skrev "Du Krøger, Dennis" < dennis.dukro...@humaninference.com>: > Hmmm... I guess it only fail for jest? It is moved into common from the > original native version, and the ES 1.4.4 PutMappi

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257986#comment-15257986 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user LosD commented on the

[GitHub] metamodel pull request: METAMODEL-244

Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/96#issuecomment-214724511 Code mostly looks good. But it is quite a bit more complicated than I expected. --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257983#comment-15257983 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user LosD commented on a di

[GitHub] metamodel pull request: METAMODEL-244

Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/96#discussion_r61075904 --- Diff: core/src/main/java/org/apache/metamodel/schema/naming/UniqueColumnNamingStrategy.java --- @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache S

[GitHub] metamodel pull request: Feature/read fixedwidth metadata files

Github user LosD commented on the pull request: https://github.com/apache/metamodel/pull/97#issuecomment-214720033 Let's wait with reviewing this until #96 has been merged and master merged here. --- If your project is set up for it, you can reply to this email and have your reply ap

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257967#comment-15257967 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user LosD commented on a di

[GitHub] metamodel pull request: METAMODEL-244

Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/96#discussion_r61074112 --- Diff: core/src/main/java/org/apache/metamodel/schema/naming/DefaultColumnNamingStrategy.java --- @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache

[GitHub] metamodel pull request: Feature/read fixedwidth metadata files

Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/97#discussion_r61074019 --- Diff: core/src/main/java/org/apache/metamodel/schema/naming/DefaultColumnNamingStrategy.java --- @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache

[jira] [Commented] (METAMODEL-244) Ability to specify column names for datastores that may not have named columns

[ https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257705#comment-15257705 ] ASF GitHub Bot commented on METAMODEL-244: -- Github user albertostratio comment

[GitHub] metamodel pull request: METAMODEL-244

Github user albertostratio commented on the pull request: https://github.com/apache/metamodel/pull/96#issuecomment-214657798 @kaspersorensen Do we need all the ColumnNamingStrategy interfaces and implementations stuff to just get the names of the columns. It seems like kinda over-engi

[GitHub] metamodel pull request: Feature/read fixedwidth metadata files

Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/97#discussion_r61039693 --- Diff: core/src/main/java/org/apache/metamodel/schema/naming/DefaultColumnNamingStrategy.java --- @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache

RE: Approach to submitting ElasticSearch mapping

Hmmm... I guess it only fail for jest? It is moved into common from the original native version, and the ES 1.4.4 PutMappingRequestBuilder explicitly supports this: https://github.com/elastic/elasticsearch/blob/v1.4.4/src/main/java/org/elasticsearch/action/admin/indices/mapping/put/PutMappingReq