[GitHub] metamodel pull request #124: Added code to remove TIMESTAMP tokens from SQLS...

2016-08-16 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/124#discussion_r75043572 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java --- @@ -116,6 +116,14 @@ public String

[GitHub] metamodel issue #124: Added code to remove TIMESTAMP tokens from SQLServer q...

2016-08-16 Thread kaspersorensen
Github user kaspersorensen commented on the issue: https://github.com/apache/metamodel/pull/124 Hi Harris, We will do it as quickly as possible, but not quicker than allowing us to vet the change properly :-) And I would guess that you also would need us to release the fix

[GitHub] metamodel pull request #125: Use ColumnNamingStrategy argument in CsvConfigu...

2016-08-16 Thread arjansh
GitHub user arjansh opened a pull request: https://github.com/apache/metamodel/pull/125 Use ColumnNamingStrategy argument in CsvConfiguration constructor Fixes METAMODEL-1113. Added unit tests to the different types of datastores which can make use of the

[GitHub] metamodel issue #124: Added code to remove TIMESTAMP tokens from SQLServer q...

2016-08-16 Thread olafgarten
Github user olafgarten commented on the issue: https://github.com/apache/metamodel/pull/124 Hi, If this is all okay can it be merged as soon as possible, we have a customer deadline very soon and need this to be done as quickly as possible. Thanks, Harris Mirza --- If

[GitHub] metamodel pull request #124: Added code to remove TIMESTAMP tokens from SQLS...

2016-08-16 Thread LosD
Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/124#discussion_r74890818 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java --- @@ -116,6 +116,14 @@ public String

[GitHub] metamodel pull request #124: Added code to remove TIMESTAMP tokens from SQLS...

2016-08-16 Thread LosD
Github user LosD commented on a diff in the pull request: https://github.com/apache/metamodel/pull/124#discussion_r74885525 --- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java --- @@ -116,6 +116,14 @@ public String