[GitHub] metamodel issue #128: Demonstrated issue with AVG function and fixed/adapted...

2016-09-07 Thread LosD
Github user LosD commented on the issue: https://github.com/apache/metamodel/pull/128 Yeah I wasn't exactly clear, sorry about that. The SQL rule is that output matches input (or at least a type that is close) and I think that's the only sane thing to do when there is no way to specif

[GitHub] metamodel issue #129: Fix DefaultCompiledQuery.copyFilterItem

2016-09-07 Thread kaspersorensen
Github user kaspersorensen commented on the issue: https://github.com/apache/metamodel/pull/129 Ouch, yes. LGTM. Would be good to have a small unittest (and that would be easy to make here) though. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] metamodel issue #128: Demonstrated issue with AVG function and fixed/adapted...

2016-09-07 Thread kaspersorensen
Github user kaspersorensen commented on the issue: https://github.com/apache/metamodel/pull/128 Do you mean "not always a double type" (instead of integer)? Or else I don't understand what you're saying? Are you simply saying that "this is the rule of SQL, so we should follow

[GitHub] metamodel pull request #129: Fix DefaultCompiledQuery.copyFilterItem

2016-09-07 Thread aportosa
GitHub user aportosa opened a pull request: https://github.com/apache/metamodel/pull/129 Fix DefaultCompiledQuery.copyFilterItem Previous version was missing the use of logical operator while calling FilterItem constructor You can merge this pull request into a Git repository by ru

[GitHub] metamodel issue #128: Demonstrated issue with AVG function and fixed/adapted...

2016-09-07 Thread LosD
Github user LosD commented on the issue: https://github.com/apache/metamodel/pull/128 If we do it differently in other connectors, we really need to fix them, not break SQL. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] metamodel issue #128: Demonstrated issue with AVG function and fixed/adapted...

2016-09-07 Thread LosD
Github user LosD commented on the issue: https://github.com/apache/metamodel/pull/128 AVG is supposed to return the same output type as input type (or, at least the same class, e.g. an integer type with tinyint, int arguments and floating point type with float or double arguments), no