+1
2017-07-27 4:25 GMT+02:00 Kasper Sørensen :
> +1
>
> 2017-07-26 19:25 GMT-07:00 Kasper Sørensen >:
>
> > Hi All,
> > Please vote on releasing the following candidate as Apache Metamodel
> > version 5.0-RC3.
> >
> > The Git tag to be voted on is MetaModel-5.0-RC3:
> > https://git-wip-us.apache
Hi All,
Please vote on releasing the following candidate as Apache Metamodel
version 5.0-RC3.
The Git tag to be voted on is MetaModel-5.0-RC3:
https://git-wip-us.apache.org/repos/asf?p=metamodel.git;a=commit;h=dc548101fc5a15615017b123eead0cfc913d46a0
The source artifact to be voted on is:
http://
+1
2017-07-26 19:25 GMT-07:00 Kasper Sørensen :
> Hi All,
> Please vote on releasing the following candidate as Apache Metamodel
> version 5.0-RC3.
>
> The Git tag to be voted on is MetaModel-5.0-RC3:
> https://git-wip-us.apache.org/repos/asf?p=metamodel.git;a=commit;h=
> dc548101fc5a15615017b123
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/148
This PR looks very good to me. I'm gonna go ahead and format the files
slightly and then merge it.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/148#discussion_r129737407
--- Diff: core/src/test/java/org/apache/metamodel/MetaModelHelperTest.java
---
@@ -115,21 +115,16 @@ public void testRightJoin() throws Exception {
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/152
Merging as per lazy consensus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/148
The point about using collections instead of arrays is a good old wishlist
item :-)
https://issues.apache.org/jira/browse/METAMODEL-7
If you're up for it, I am 100% behind it. B
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/151
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel-membrane/pull/1
Oh, and the build failure is because we need a release of MM first to avoid
SNAPSHOT dependencies :-)
---
If your project is set up for it, you can reply to this email and have your
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/151
Merging as per lazy consensus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel-membrane/pull/1
I suggest to merge and then fix those remaining cosmetic things as separate
PRs if we have a way to automate it?
---
If your project is set up for it, you can reply to this email an
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel-membrane/pull/1#discussion_r129734515
--- Diff: core/pom.xml ---
@@ -0,0 +1,104 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchem
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel-membrane/pull/1#discussion_r129734366
--- Diff:
core/src/main/java/org/apache/metamodel/membrane/app/CachedDataSourceRegistryWrapper.java
---
@@ -0,0 +1,109 @@
+/**
+ *
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel-membrane/pull/1#discussion_r129522375
--- Diff:
core/src/main/java/org/apache/metamodel/membrane/app/CachedDataSourceRegistryWrapper.java
---
@@ -0,0 +1,109 @@
+/**
--- End diff -
16 matches
Mail list logo
