Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/153
Great. That makes sense. I expect to take a closer look at the diff
sometime this weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user tomatophantastico commented on the issue:
https://github.com/apache/metamodel/pull/153
IIRC, guava is only in the test cases, so i would just set the scope to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel-membrane/pull/1#discussion_r130111763
--- Diff:
core/src/main/java/org/apache/metamodel/membrane/controllers/ColumnController.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licensed
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/153
I also wanna applaude this big effort :-) But like @LosD I am a bit
concerned with adding Guava to the core module because that means our API and
really core classes essentially depends on
Github user tomatophantastico commented on the issue:
https://github.com/apache/metamodel/pull/153
Sorry, this was more of the reasoning behind my bulk changes & the changes
in the (im)mutable table class, the implementor should of course pick what fits
the scenario best.
---
If yo
Github user LosD commented on the issue:
https://github.com/apache/metamodel/pull/153
I don't really agree on "ArrayLists should be used", especially for
single-element lists, as a singletonList does not need a backing array, but
it's not really a blocker for me.
---
If your project
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130093372
--- Diff: core/src/main/java/org/apache/metamodel/CompositeDataContext.java
---
@@ -190,9 +183,7 @@ public Schema getSchemaByNameInternal(String name)
throw
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130092580
--- Diff:
core/src/main/java/org/apache/metamodel/data/AbstractRowBuilder.java ---
@@ -68,7 +71,7 @@ public AbstractRowBuilder(Column[] columns) {
Github user tomatophantastico commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130083327
--- Diff: core/src/main/java/org/apache/metamodel/convert/Converters.java
---
@@ -136,15 +135,19 @@ public static DataContext
addTypeConverters
Github user tomatophantastico commented on the issue:
https://github.com/apache/metamodel/pull/153
w.r.t. guavas Lists.newArrayList()
I think i used it mainly in the testcases, purely for syntactic convenience.
Internally ArrayLists should be used as it allows for more fre
Github user tomatophantastico commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130074475
--- Diff:
core/src/main/java/org/apache/metamodel/data/AbstractRowBuilder.java ---
@@ -68,7 +71,7 @@ public AbstractRowBuilder(Column[] columns)
Github user tomatophantastico commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130074087
--- Diff:
core/src/main/java/org/apache/metamodel/DeleteAndInsertBuilder.java ---
@@ -103,7 +103,10 @@ private Row update(final Row original) {
Github user tomatophantastico commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130073934
--- Diff: core/src/main/java/org/apache/metamodel/CompositeDataContext.java
---
@@ -190,9 +183,7 @@ public Schema getSchemaByNameInternal(String
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130068661
--- Diff: core/src/main/java/org/apache/metamodel/convert/Converters.java
---
@@ -188,7 +191,7 @@ private static void
autoDetectConvertersInternally(DataCon
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130069887
--- Diff: core/src/main/java/org/apache/metamodel/convert/Converters.java
---
@@ -136,15 +135,19 @@ public static DataContext
addTypeConverters(DataContext
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130067260
--- Diff: core/src/main/java/org/apache/metamodel/CompositeDataContext.java
---
@@ -190,9 +183,7 @@ public Schema getSchemaByNameInternal(String name)
throw
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130068074
--- Diff:
core/src/main/java/org/apache/metamodel/DeleteAndInsertBuilder.java ---
@@ -103,7 +103,10 @@ private Row update(final Row original) {
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/153#discussion_r130070891
--- Diff:
core/src/main/java/org/apache/metamodel/data/AbstractRowBuilder.java ---
@@ -68,7 +71,7 @@ public AbstractRowBuilder(Column[] columns) {
GitHub user tomatophantastico opened a pull request:
https://github.com/apache/metamodel/pull/153
Collections instead of Arrays
This solves METAMODEL-7
This is a major API change, proceed with caution.
Lists are used in cases where order is important (schemas, tabl
Github user tomatophantastico commented on a diff in the pull request:
https://github.com/apache/metamodel-membrane/pull/1#discussion_r130057536
--- Diff:
core/src/main/java/org/apache/metamodel/membrane/controllers/ColumnController.java
---
@@ -0,0 +1,86 @@
+/**
+ * Licen
20 matches
Mail list logo
