[GitHub] metamodel issue #183: add support for Oracle "TIMESTAMP WITH (LOCAL_)TIME_ZO...

2018-08-13 Thread LingHao
Github user LingHao commented on the issue: https://github.com/apache/metamodel/pull/183 Sorry for tabs, I didn't notice the Coding guidelines. Do I need to fix them and PR again? ---

[GitHub] metamodel issue #183: add support for Oracle "TIMESTAMP WITH (LOCAL_)TIME_ZO...

2018-08-13 Thread kaspersorensen
Github user kaspersorensen commented on the issue: https://github.com/apache/metamodel/pull/183 Seems like a clean fix to me. Only remark is that you've used tabs instead of spaces in the Oracle class. ---

[GitHub] metamodel pull request #183: add support for Oracle "TIMESTAMP WITH (LOCAL_)...

2018-08-13 Thread LingHao
GitHub user LingHao opened a pull request: https://github.com/apache/metamodel/pull/183 add support for Oracle "TIMESTAMP WITH (LOCAL_)TIME_ZONE" column type. Oracle has "TIMESTAMP WITH LOCAL_TIME_ZONE" and TIMESTAMP WITH TIME_ZONE" column type, which MetaModel doesn't support now.