Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/74#issuecomment-162330048
Hehe, yeah. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/74#issuecomment-162326879
Agree. This was unintentional and just muscle-memory driven. Will fix it.
Maybe we can put the eclipse formatting rules somewhere so that one can make
sure he i
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/74#issuecomment-162326084
LGTM, but I'm really no fan of reformatting an entire file unless we touch
much of the file. It makes reviews much harder than they need to be, and
destroys history.
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/74#discussion_r46772088
--- Diff:
jdbc/src/test/java/org/apache/metamodel/jdbc/JdbcDataContextTest.java ---
@@ -148,20 +148,22 @@ public void testExecuteQuery() throws Exception {
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/74#discussion_r46772077
--- Diff:
jdbc/src/test/java/org/apache/metamodel/jdbc/JdbcDataContextTest.java ---
@@ -261,6 +265,20 @@ public void testWhereScalarFunction() throws Exception
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/74#issuecomment-162249437
Update the PR with more tests and made the JDBC module fail fast. Will
update my previous PR description accordingly.
Now this is ready for a final revi
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/74
Added new aggregate functions FIRST, LAST, RANDOM
Just sharing this little idea that I had while travelling the other day ...
Adding some more aggregate functions to MetaModel.
*
