Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user ashish-m-yh commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-91915
Did you have a chance to look at this sometime?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ashish-m-yh commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-105260918
METAMODEL-129: Commited
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user ashish-m-yh commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-104870675
I used checkstyle static code analyzer to identify number of style issues
(including the ones you raised) and fixed them.
However, throwing out DefaultHttp
Github user ashish-m-yh commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-104367630
It's fine. Things should be proper. On further review, I found some of the
issues you reported, but it's weird why my Eclipse doesn't show it when I
import the mvn
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-104020512
Sorry that I keep asking you for changes like this, we'll be happy at the
end of it all :-)
---
If your project is set up for it, you can reply to this email a
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-104020116
A couple of remarks on code style:
* In eclipse I see a bunch of warnings that should be fixed:
* Unused variables (multiple)
* Unused impor
Github user ashish-m-yh commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-103317824
Introduced the "fetch all" mechanism as described on the link you found.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-102836764
If you run a broad query like "SELECT * FROM [table]" then it should be
able to get the results and not apply a limit. Not necesarily as part of the
same reques
Github user ashish-m-yh commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-102798147
I understand the philosophy. We may sacrifice performance to conform to a
general standard. I have implemented only the necessary methods.
Note: Only neces
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-98796448
Hi Ashish,
I know that doing a JOIN is pretty unusual in "normal" mode of Solr. But in
my opinion we are also not catering to the normal cases. MetaModel
Github user ashish-m-yh commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-98772705
Thank you for the detailed comments. I concur in part - some corner cases
may need handling. Some kinds of queries, such as joins are rarely used in Solr
and the su
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29597584
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Found
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29597620
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Found
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29597555
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Found
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29597418
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Found
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29596247
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Found
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29596296
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Found
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/19#issuecomment-98612112
Sorry that was a lot of nitty gritty details. I am just trying to show that
implementing executeQuery(...) is very complex because the Query object is
complex. I
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569934
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569880
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569699
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569636
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569521
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569465
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569413
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569356
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569243
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569265
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,396 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29569223
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,403 @@
+/**
+ * Licensed to the Apache Software Fo
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29445084
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,403 @@
+/**
+ * Licensed to the Apache Software Found
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29271324
--- Diff:
solr/src/test/java/org/apache/metamodel/solr/SolrDataContextTest1.java ---
@@ -0,0 +1,199 @@
+/**
+ * Licensed to the Apache Software
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29240604
--- Diff:
solr/src/test/java/org/apache/metamodel/solr/SolrDataContextTest1.java ---
@@ -0,0 +1,199 @@
+/**
+ * Licensed to the Apache Software
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29240261
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,403 @@
+/**
+ * Licensed to the Apache Software Found
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29240046
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,403 @@
+/**
+ * Licensed to the Apache Software Found
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29239910
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,403 @@
+/**
+ * Licensed to the Apache Software Found
Github user ashish-m-yh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29239757
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataSet.java ---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29112631
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,403 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29112578
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,403 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29112571
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,403 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29112568
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataContext.java
---
@@ -0,0 +1,403 @@
+/**
+ * Licensed to the Apache Software Fo
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29112490
--- Diff:
solr/src/test/java/org/apache/metamodel/solr/SolrDataContextTest1.java ---
@@ -0,0 +1,199 @@
+/**
+ * Licensed to the Apache Softwa
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29112462
--- Diff:
solr/src/test/java/org/apache/metamodel/solr/SolrDataContextTest1.java ---
@@ -0,0 +1,199 @@
+/**
+ * Licensed to the Apache Softwa
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/19#discussion_r29112457
--- Diff: solr/src/main/java/org/apache/metamodel/solr/SolrDataSet.java ---
@@ -0,0 +1,174 @@
+/**
+ * Licensed to the Apache Software Foundat
GitHub user ashish-m-yh opened a pull request:
https://github.com/apache/metamodel/pull/19
Fresh PR for Sor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ashish-m-yh/metamodel master
Alternatively you can review and apply thes
45 matches
Mail list logo
