Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user ardlema commented on the pull request:
https://github.com/apache/metamodel/pull/43#issuecomment-135537440
Yes I agree. I guess this is the best worst option. I'll merge this into
master tomorrow morning then.
Thank you @kaspersorensen @LosD for your comments!
---
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/43#issuecomment-135536364
Yep! I'm no fan of allowing stuff the schema doesn't, but if we can't get
ES to help us out, we don't really have a choice.
---
If your project is set up for it, you can
Github user ardlema commented on the pull request:
https://github.com/apache/metamodel/pull/43#issuecomment-135530537
@LosD is this also ok with you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/43#issuecomment-135426789
+1 from me then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/43#discussion_r38093822
--- Diff:
elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDateConverter.java
---
@@ -0,0 +1,41 @@
+/**
+ * Licen
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/43#discussion_r38073796
--- Diff:
elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDateConverter.java
---
@@ -0,0 +1,41 @@
+/**
+ * Licen
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/43#discussion_r37984410
--- Diff:
elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDateConverter.java
---
@@ -0,0 +1,41 @@
+/**
+ * Licensed to the
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/43#discussion_r37983155
--- Diff:
elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDateConverter.java
---
@@ -0,0 +1,41 @@
+/**
+ * Licen
Github user albertostratio commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/43#discussion_r37948995
--- Diff:
elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDateConverter.java
---
@@ -0,0 +1,39 @@
+/**
+ * Licen
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/43#discussion_r37858020
--- Diff:
elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDateConverter.java
---
@@ -0,0 +1,39 @@
+/**
+ * Licen
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/43#issuecomment-134537945
@kaspersorensen as per your suggestion I moved the date parsing to the ES
module instead of using the TypeComparator class
---
If your project is set up for it
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/43#discussion_r37730850
--- Diff:
elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchUtils.java
---
@@ -44,8 +47,17 @@ public static Row createRow(
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/43#discussion_r37730788
--- Diff:
core/src/test/java/org/apache/metamodel/util/TimeComparatorTest.java ---
@@ -66,6 +66,9 @@ public void testToDate() throws Exception {
GitHub user ardlema opened a pull request:
https://github.com/apache/metamodel/pull/43
METAMODEL-172: Adding Date parsing to ES module
When working with ElasticSearch indexes that contains Date types the API is
returning Strings instead of proper Date objects. We found out this prob
15 matches
Mail list logo
