Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/86
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/86#issuecomment-174198524
I will merge it in - it's certainly an improvement and a great contribution
- thank you @xmpy !
---
If your project is set up for it, you can reply to this ema
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/86#issuecomment-174198426
I'm certainly no MongoDB expert, so I may not be the right one to ask, but
the code itself looks good to me! :)
---
If your project is set up for it, you can reply to th
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/86#issuecomment-174196696
Sorry I kinda had to drop off the MetaModel activity shortly because I had
some important work to do at work. I'm very satisfied with this PR.
Let's ask
Github user xmpy commented on the pull request:
https://github.com/apache/metamodel/pull/86#issuecomment-173864830
Hi @kaspersorensen , any comments? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/86#issuecomment-170930123
Yes let's change the ```full``` module to prefer the mongo3 implementation.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user xmpy commented on the pull request:
https://github.com/apache/metamodel/pull/86#issuecomment-170926968
I still have a little concern about
org.apache.metamodel.DataContextFactory, in this factory, we return the mongo2
MongoDataContext. In the pom of this `full` maven proje
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/86#issuecomment-170384037
This PR has my +1 now
For extra sugar on top, I did notice a few minor warnings which could be
fixed before we push this to master:
I do followings things in these 3 commits.
1. remove .classpath
2. make mongodb-common module work for bo
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/86#issuecomment-169981096
Thank you for the very good contribution! I have made a few remarks, but
general feeling is that it looks good!
---
If your project is set up for it, you can r
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/86#discussion_r49182098
--- Diff: mongodb/common/pom.xml ---
@@ -0,0 +1,66 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchem
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/86#discussion_r49182057
--- Diff: mongodb/mongo2/pom.xml ---
@@ -0,0 +1,70 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchem
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/86#discussion_r49181994
--- Diff:
mongodb/common/src/main/java/org/apache/metamodel/mongodb/common/MongoDBUtils.java
---
@@ -73,5 +101,29 @@ private static Object toValue(C
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/86#discussion_r49181840
--- Diff: mongodb/common/.classpath ---
@@ -0,0 +1,26 @@
+
+
--- End diff --
Let's not add .classpath or other IDE-specific files
GitHub user xmpy opened a pull request:
https://github.com/apache/metamodel/pull/86
METAMODEL-183: Upgrad MongoDB API and seperate MongoDB module into monâ¦
Take over @loorenzooo 's work. Thank you very much.
Besides loorenzooo's work, I also do following works:
1. Seperate
15 matches
Mail list logo
