Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/99#issuecomment-218893382
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/99#discussion_r63100869
--- Diff:
couchdb/src/test/java/org/apache/metamodel/couchdb/CouchDbDataContextTest.java
---
@@ -53,7 +53,8 @@ protected void setUp() throws Exception {
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/99#discussion_r63100757
--- Diff:
couchdb/src/test/java/org/apache/metamodel/couchdb/CouchDbDataContextTest.java
---
@@ -53,7 +53,8 @@ protected void setUp() throws Exception {
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/99
METAMODEL-244: Added support for Excel datastore as well
I realised that although METAMODEL-244 was 'fixed', I had not applied the
technique to the 'Excel' module. This PR does that.
You c
