[GitHub] metamodel pull request: Maven-assembly-plugin in MetaModel-full.

2015-10-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metamodel/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] metamodel pull request: Maven-assembly-plugin in MetaModel-full.

2015-10-21 Thread kaspersorensen
Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/60#issuecomment-149824922 Looks very nice now. I'll do a quick run locally to verify the zip file's contents. And then merge :-) --- If your project is set up for it, you can reply to t

[GitHub] metamodel pull request: Maven-assembly-plugin in MetaModel-full.

2015-10-20 Thread kaspersorensen
Github user kaspersorensen commented on the pull request: https://github.com/apache/metamodel/pull/60#issuecomment-149536285 This looks quite alright, except I am a bit wondering about two ugly things in the diff: * The license header in pom.xml files is screwed. * The l

[GitHub] metamodel pull request: Maven-assembly-plugin in MetaModel-full.

2015-10-20 Thread tomaszguzialek
Github user tomaszguzialek commented on the pull request: https://github.com/apache/metamodel/pull/60#issuecomment-149510367 The build failed because of Cassandra cluster not starting within timeout, so unrelated issue. --- If your project is set up for it, you can reply to this emai

[GitHub] metamodel pull request: Maven-assembly-plugin in MetaModel-full.

2015-10-20 Thread tomaszguzialek
GitHub user tomaszguzialek opened a pull request: https://github.com/apache/metamodel/pull/60 Maven-assembly-plugin in MetaModel-full. During "package" phase it creates the distributable version in target folder of the MetaModel-full module. Fixes METAMODEL-144 You can mer