Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/78#issuecomment-164193164
Good solution. :+1:, then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/78#issuecomment-164190432
OK as you can now see from the latest commit
(0e0a9fb4c76ce396f15c66094f52abf8bb366a0a) I have added a system property
```metamodel.hadoop.use_hadoop_conf_dir``
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/78#issuecomment-164189119
Fixed the EOLs.
That's a very good question actually... You're right that it would override
```fs.defaultFS```, and initially that was also my intention
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/78#issuecomment-164058639
Isn't it dangerous reuse existing Hadoop/Yarn environment variables? They
may be set globally without being intended for use with whatever is using
MetaModel, and they wi
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/78#discussion_r47408930
--- Diff: hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java
---
@@ -369,30 +307,19 @@ public Path getHadoopPath() {
@Override
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/78#discussion_r47408874
--- Diff: core/src/main/java/org/apache/metamodel/util/FileHelper.java ---
@@ -263,40 +259,16 @@ public static void safeClose(Object... objects) {
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/78#discussion_r47408815
--- Diff:
hadoop/src/main/java/org/apache/metamodel/util/HdfsFileOutputStream.java ---
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Founda
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/78#discussion_r47408806
--- Diff:
hadoop/src/main/java/org/apache/metamodel/util/HdfsFileInputStream.java ---
@@ -0,0 +1,88 @@
+/**
+ * Licensed to the Apache Software Foundat
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/78#discussion_r47408779
--- Diff:
hadoop/src/main/java/org/apache/metamodel/util/HdfsDirectoryInputStream.java ---
@@ -0,0 +1,74 @@
+/**
+ * Licensed to the Apache Software Fo
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/78
Read hadoop configuration files (core-site.xml and hdfs-site.xml) in
HdfsResource
Suggested fix for METAMODEL-219.
I did a few minor/additional changes too:
* Moved the H
11 matches
Mail list logo
