[GitHub] metamodel pull request #148: Feature/faster join

2017-07-27 Thread tomatophantastico
Github user tomatophantastico commented on a diff in the pull request: https://github.com/apache/metamodel/pull/148#discussion_r129790017 --- Diff: core/src/test/java/org/apache/metamodel/MetaModelHelperTest.java --- @@ -115,21 +115,16 @@ public void testRightJoin() throws Exceptio

[GitHub] metamodel pull request #148: Feature/faster join

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metamodel/pull/148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] metamodel pull request #148: Feature/faster join

2017-07-26 Thread kaspersorensen
Github user kaspersorensen commented on a diff in the pull request: https://github.com/apache/metamodel/pull/148#discussion_r129737407 --- Diff: core/src/test/java/org/apache/metamodel/MetaModelHelperTest.java --- @@ -115,21 +115,16 @@ public void testRightJoin() throws Exception {

[GitHub] metamodel pull request #148: Feature/faster join

2017-07-21 Thread tomatophantastico
GitHub user tomatophantastico opened a pull request: https://github.com/apache/metamodel/pull/148 Feature/faster join A simple nested loop join implementation to deal with METAMODEL-1144. This is an okay-ish solution: it maintains the results of the joins, but wont scale