Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/796
I think the test coverage looks pretty good. I'm +1 conditional on the e2e
tests passing.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/811
Master is merged in, so this Travis run should be legit
---
Casey's PR has been committed into master. Please update any branches/PRs
as needed.
On Wed, Oct 25, 2017 at 3:56 PM, Casey Stella wrote:
> I expect that can be done via an infra request. Not sure though.
>
> On Wed, Oct 25, 2017 at 3:33 PM, Justin Leet
> wrote:
>
> > To hop onto Otto's comme
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/816
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/816
I agree we leave it as-is.
---
Github user iraghumitra commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146991821
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts
---
@@ -337,12 +343,67 @@ export class TreeViewComp
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/796
@merrimanr I have added e2e tests as suggested and merged your PR too. Plz,
let me know if I missed anything. I had to omit assertions for a couple of
quick ranges as they can cause trouble when
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/816
Agree with @mmiklavc comment.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/816
@cestella @mattf-horton - I don't think the commit hurts anything, so no
point in removing it now that it's in. But I do agree with otto that it would
be better to use $METRON_HOME and that this cou
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/816
Yeah, I agree that it doesn't materially affect the example. I decided to
adjust it anyway excepting the names of the rpms. Perhaps I should revert the
commit. Thoughts?
---
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146979225
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts
---
@@ -337,12 +343,67 @@ export class TreeViewCompo
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/816
@mmiklavc and @cestella regarding "0.4.1" references in README.md files,
please see https://github.com/apache/metron/pull/767 , specifically Otto's
comment https://github.com/apache/metron/pull/
I expect that can be done via an infra request. Not sure though.
On Wed, Oct 25, 2017 at 3:33 PM, Justin Leet wrote:
> To hop onto Otto's comment, it would be really nice to have master build
> failures go to the dev list. I have no idea who has permissions to set
> that up though, so if anyon
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/811
Travis failure should be resolved once
https://github.com/apache/metron/pull/816 is in, and I'll merge in master and
push again once it is.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/811
@nickwallen I added testing around the status stuff, and a couple docs. Let
me know if there's anything else that should be updated (or isn't clear or
whatever else).
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/816
I just found a few more references to 0.4.1. We should probably change
paths from explicit version paths to $METRON_HOME in README's. We probably
don't want to tackle this here. We should fix the bu
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/816
I found a couple of refs to 0.4.1 in the profiler READMEs. I went ahead
and corrected them while I was in there.
---
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/811#discussion_r146965770
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -295,19 +341,199 @
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/803#discussion_r146964503
--- Diff:
metron-interface/metron-alerts/src/app/alerts/alerts-list/tree-view/tree-view.component.ts
---
@@ -337,12 +343,67 @@ export class TreeViewCompo
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/816
+1 by inspection
---
To hop onto Otto's comment, it would be really nice to have master build
failures go to the dev list. I have no idea who has permissions to set
that up though, so if anyone does that'd be super helpful.
On Wed, Oct 25, 2017 at 3:14 PM, Casey Stella wrote:
> I noticed it on my personal travis th
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/816
+1 by inspection, pending Travis
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/816
+1 by inspection, pending Travis
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/767
Needed to re-kick Travis to be sure.
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/767
Sorry about that, folks. In future I won't trust github when it says it
will still merge "without conflict".
---
I noticed it on my personal travis the when I merged in apache master.
BTW: the PR for the fix is https://github.com/apache/metron/pull/816
On Wed, Oct 25, 2017 at 3:13 PM, Otto Fowler
wrote:
> Do you get the travis alerts for failed builds? If not who does?
>
>
> On October 25, 2017 at 15:12
Do you get the travis alerts for failed builds? If not who does?
On October 25, 2017 at 15:12:46, Otto Fowler (ottobackwa...@gmail.com)
wrote:
Thanks Casey
On October 25, 2017 at 15:11:34, Casey Stella (ceste...@gmail.com) wrote:
I got it. I made a JIRA and have a fix in the middle of testin
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/816
METRON-1280: 0.4.1 -> 0.4.2 missed a couple of projects
## Contributor Comments
The version bump missed a couple of projects that were added between when
the PR for the version bump was created
Thanks Casey
On October 25, 2017 at 15:11:34, Casey Stella (ceste...@gmail.com) wrote:
I got it. I made a JIRA and have a fix in the middle of testing:
https://issues.apache.org/jira/browse/METRON-1280
On Wed, Oct 25, 2017 at 3:09 PM, Otto Fowler
wrote:
> https://travis-ci.org/search/apache%2
I got it. I made a JIRA and have a fix in the middle of testing:
https://issues.apache.org/jira/browse/METRON-1280
On Wed, Oct 25, 2017 at 3:09 PM, Otto Fowler
wrote:
> https://travis-ci.org/search/apache%252Fmetron
>
> I believe it is to do with https://github.com/apache/metron/pull/767, and
>
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/767
Ok, Master is broken in travis as well
---
https://travis-ci.org/search/apache%252Fmetron
I believe it is to do with https://github.com/apache/metron/pull/767, and
the missed addition of metron-zookeeper.
My Pr’s that I’m merging master into are fixed by upping the
metron-zookeeper version to 0.4.2.
I would fix this, but I have to run out.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/767
Yeah, I got it. https://issues.apache.org/jira/browse/METRON-1280
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/767
So, between the original scan and the commit,
metron-platform/metron-zookeeper was added. It is not addressed in this. I'm
trying to get a PR updated with this, but cannot get metron-test-uti
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/797
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/797
Makes sense to me. +1 Nice job
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/797
and by downstream, I mean in whatever UI we have.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/797
So, I did think about this and decided to include it. It is an index in ES
with data. If we think it should be filtered, I can certainly do so, but
thought the decision really should be best done
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/811#discussion_r146937137
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -295,19 +341,199 @
Thanks, Jon. I’ve committed the patch.
--Matt
On 10/25/17, 9:26 AM, "zeo...@gmail.com" wrote:
I still kind of like the build image historically, since not everybody who
interfaces with our project will _know_ that the build must always succeed
for a release, but I agree that this is
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/767
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/797
Just tested this and worked as expected. The only question I have is
whether the "error" index should be included since it is used to store errors
and not alerts. I can't think of a case where yo
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/767
Thanks, @ottobackwards and @kylerichardson . Committing...
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/811#discussion_r146925677
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -295,19 +341,199 @
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/815
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/815
Thanks, everyone. Committing...
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/815
+1 by inspection, thanks @mattf-horton
---
I still kind of like the build image historically, since not everybody who
interfaces with our project will _know_ that the build must always succeed
for a release, but I agree that this is a clean approach so I rolled back
the wiki changes. Thanks,
Jon
On Tue, Oct 24, 2017 at 2:34 PM Matt Foley
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/811#discussion_r146899435
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -295,19 +341,199 @
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/811
### Testing
Testing purely based on the REST API. Having said that, if you want to do
like @nickwallen did and pull in https://github.com/apache/metron/pull/803 into
the same branch, you shoul
One last thing, I'd recommend that master get merged into everyone's
branches/PRs to make sure the tests work consistently during any necessary
Travis runs.
On Wed, Oct 25, 2017 at 9:29 AM, Justin Leet wrote:
> Master is building again! Thanks to Ryan for taking care of it. We should
> be good
Master is building again! Thanks to Ryan for taking care of it. We should
be good to go with committing again.
Thanks for your patience everyone.
On Mon, Oct 23, 2017 at 10:06 AM, Casey Stella wrote:
> Looks like Ryan got there first, which is awesome. Thanks for cleaning up
> my mess :)
>
>
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/815
+1 by inspection. Thanks for grabbing this so quickly!
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/811#discussion_r146848022
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template
---
@@ -154,
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/811#discussion_r146847834
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -295,19 +341,199 @
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/811#discussion_r146827154
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -295,19 +341,199 @
Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/811#discussion_r146826488
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template
---
@@ -154,
57 matches
Mail list logo
