Github user anandsubbu commented on a diff in the pull request:
https://github.com/apache/metron/pull/888#discussion_r161955419
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
---
@@
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/899
Just in case: Note that that test is modified from your test ( _o )
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161919259
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/899
I'll look into the test as it's passing locally for me in my IDE.
---
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161913450
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public Object
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161912600
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public Object
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161911833
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public Object
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/899
This tests fails, I think something is wrong.
```java
@Test
public void
boyerMoore_calculates_plurality_from_list_of_mixed_objects_o() throws Exception
{
List items
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/785
well then.
In a world where 777 didn't exist I would be a +1.
In world where 777 does exist, i'm a +0, since I feel the effort would have
been better spent reviewing 777, but think
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/882
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/785
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/882
+1, thanks for the hard work in getting everything cleaned up!
---
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/879
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161821411
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/899#discussion_r161817448
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/MathFunctions.java
---
@@ -220,4 +219,156 @@ public
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/879
+0 I'm sure what's here is solid, but I have not reviewed it myself. I
just want to clear the way for this to get merged.
I don't necessarily like the usability of this approach, but I
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/786
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
@merrimanr I am +1 on getting this down to the feature branch and moving on.
Due to the way the feature branch works, I think it is OK to do so if
@cestella doesn't get back in time. It's
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/888#discussion_r161746734
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
---
@@
Github user anandsubbu commented on a diff in the pull request:
https://github.com/apache/metron/pull/888#discussion_r161735380
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
---
@@
20 matches
Mail list logo
