[GitHub] metron issue #946: METRON-1465:Support for Elasticsearch X-pack

2018-03-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/946 thanks @mmiklavc ---

[GitHub] metron issue #946: METRON-1465:Support for Elasticsearch X-pack

2018-03-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/946 @ottobackwards - I have some open changes in a PR against this PR. Just to confirm, the expected result of this PR should be that users can choose 1. Which client they want to instantiate 2.

[GitHub] metron pull request #965: METRON-590 Enable Use of Event Time in Profiler

2018-03-15 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/965 METRON-590 Enable Use of Event Time in Profiler This enables the use of event time processing in the Profiler. By default, the Profiler will still use processing time. If you configure

[GitHub] metron pull request #914: METRON-1397 Support for JSON Path and complex docu...

2018-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/914 ---

[GitHub] metron issue #914: METRON-1397 Support for JSON Path and complex documents i...

2018-03-15 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/914 I love this, sorry I didn't review it sooner @ottobackwards +1 by inspection. This is great. ---

[GitHub] metron pull request #959: METRON-1485 Upgrade vagrant for dev environments

2018-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/959 ---

[GitHub] metron pull request #924: METRON-1299 In MetronError tests, don't test for H...

2018-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/924 ---

[GitHub] metron issue #959: METRON-1485 Upgrade vagrant for dev environments

2018-03-15 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/959 +1 by inspection, thanks Jon! ---

[GitHub] metron pull request #962: METRON-1488: user_settings hbase table does not ha...

2018-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/962 ---

[GitHub] metron pull request #963: METRON-1490: Better error message when user specif...

2018-03-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/963 ---

[GitHub] metron issue #964: METRON-1491: The indexing topology restart logic is wrong

2018-03-15 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/964 Ok, created [METRON-1492](https://issues.apache.org/jira/browse/METRON-1492). ---

[GitHub] metron issue #964: METRON-1491: The indexing topology restart logic is wrong

2018-03-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/964 Yes, lets get it in there ---

[GitHub] metron issue #964: METRON-1491: The indexing topology restart logic is wrong

2018-03-15 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/964 @ottobackwards yeah, definitely; I think that's ultimately where we want to go. The first step to that is separating out these functions like I have in this PR. The next is doing the ambari work w

[GitHub] metron issue #964: METRON-1491: The indexing topology restart logic is wrong

2018-03-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/964 Should we think about exposing them as separate things in ambari over all? Go all the way with this? ---

[GitHub] metron pull request #964: METRON-1491: The indexing topology restart logic i...

2018-03-15 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/964 METRON-1491: The indexing topology restart logic is wrong ## Contributor Comments If either topology is down, Ambari shows all of Indexing as dead. Clicking start attempts to start them both an

[GitHub] metron issue #963: METRON-1490: Better error message when user specifies an ...

2018-03-15 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/963 +1 LGTM ---

[GitHub] metron issue #963: METRON-1490: Better error message when user specifies an ...

2018-03-15 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/963 +1 via inspection ---

[GitHub] metron issue #962: METRON-1488: user_settings hbase table does not have acls...

2018-03-15 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/962 +1 looks good. thanks ---

[GitHub] metron pull request #958: METRON-1483: Create a tool to monitor performance ...

2018-03-15 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/958#discussion_r174787158 --- Diff: metron-contrib/metron-performance/src/main/java/org/apache/metron/performance/load/SendToKafka.java --- @@ -0,0 +1,107 @@ +/** + * Licens

[GitHub] metron pull request #961: METRON-1487 Define Performance Benchmarks for Enri...

2018-03-15 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/961#discussion_r174772238 --- Diff: metron-platform/metron-enrichment/Performance.md --- @@ -0,0 +1,527 @@ + + +# Enrichment Performance + +This guide defines a