[GitHub] metron issue #619: METRON-939 Elasticsearch ES5 with Xshield client support

2018-02-10 Thread wardbekker
Github user wardbekker commented on the issue: https://github.com/apache/metron/pull/619 agreed @nickwallen ---

[GitHub] metron issue #619: METRON-939 Elasticsearch ES5 with Xshield client support

2018-02-10 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/619 This functionality was completed in #840. As mentioned in #840 this inspired much of that work. Is there anything else needed from this PR? If not, can you close this PR @wardbekker ?

[GitHub] metron issue #619: METRON-939 Elasticsearch ES5 with Xshield client support

2017-09-19 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/619 As a note, this ticket is slightly impacted by the metaalerts backend ticket (https://github.com/apache/metron/pull/734). The alerts field in the various templates should be removed and the

[GitHub] metron issue #619: METRON-939 Elasticsearch ES5 with Xshield client support

2017-07-27 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/619 Seems like this is failing on some un-related temporary test failures. Can we get Travis kicked, and see what's left to do on this? --- If your project is set up for it, you can reply to

[GitHub] metron issue #619: METRON-939 Elasticsearch ES5 with Xshield client support

2017-07-06 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/619 Do we not have to re-write the ambari service? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #619: METRON-939 Elasticsearch ES5 with Xshield client support

2017-07-05 Thread wardbekker
Github user wardbekker commented on the issue: https://github.com/apache/metron/pull/619 @JonZeolla done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] metron issue #619: METRON-939 Elasticsearch ES5 with Xshield client support

2017-07-05 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/619 @wardbekker Can you please merge master and deconflict? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] metron issue #619: METRON-939 Elasticsearch ES5 with Xshield client support

2017-06-27 Thread wardbekker
Github user wardbekker commented on the issue: https://github.com/apache/metron/pull/619 hey @cestella, @simonellistonball, see updated contributor notes. It's not ready for a official pull request, but this gives a good idea on the impact on the code for a working ES5.x

[GitHub] metron issue #619: METRON-939 Elasticsearch ES5 with Xshield client support

2017-06-19 Thread wardbekker
Github user wardbekker commented on the issue: https://github.com/apache/metron/pull/619 Thanks for the review @cestella I've pushed a commit fixing the reported issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.