[GitHub] metron issue #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-26 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/667 +1 Looks good. Thanks for all the hard work, Otto. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] metron issue #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-23 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/667 Yes, I have some outstanding comments that Otto hasn't responded to yet. It is in the "fold" which is why they were probably missed. https://github.com/apache/metron/pull/667#discussion_r

[GitHub] metron issue #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-22 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/667 @nickwallen Any additional comments? This looks good to me, happy to do additional testing if needed but I did spin this up a week back --- If your project is set up for it, you can reply to this

[GitHub] metron issue #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-15 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/667 I'm fine with this so far, but will hold for @nickwallen 's +1. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] metron issue #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-08-13 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/667 @cestella are we all set with the changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] metron issue #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-07-27 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/667 @JonZeolla --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] metron issue #667: METRON-1061 Add FUZZY_SCORE STELLAR function

2017-07-25 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/667 Oh ProfilerIntegrationTest you've done it again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th