[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/710 @nickwallen we can make the fields configurable too. ---

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/710 +1 That works for me. This is a good first pass. Taking care of METRON-1250 would totally side step a probably contentious (and unwinnable) debate as to what the most important fields are. :)

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread james-sirota
Github user james-sirota commented on the issue: https://github.com/apache/metron/pull/710 Ok, I opened https://issues.apache.org/jira/browse/METRON-1250 as a follow on jira for this ---

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/710 @nickwallen The idea is to have the Facets and Groups in sync with the table column names at the same time avoid the ones that might be too discrete. I will have a discussion around what's the be

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/710 Everything else is looking really good though, @iraghumitra . * The way that the UI it is laid out is obvious and intuitive. * I manually tested the faceted functionality and all the count

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/710 > A new facet pane is added to GUI that groups data based on the following 'hard coded' fields ('source:type', 'ip_src_addr', 'ip_dst_addr', 'host', 'enrichments:geo:ip_dst_addr:country')

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread iraghumitra
Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/710 @nickwallen The PR was raised before I go to know about the concept of squash commits mind me for my ignorance. I had to make few modifications since a PR that was raised after this got in to mas

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-13 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/710 Hi @iraghumitra - The commit history looks a little odd. There are commits going back a few months and seem unrelated to this PR. Can you double check that the code that you have submitted is wh

[GitHub] metron issue #710: Metron-1083: Add filters using faceted search capabilitie...

2017-10-12 Thread james-sirota
Github user james-sirota commented on the issue: https://github.com/apache/metron/pull/710 I can't comment on implementation details, but + 1 on the capabilities. I spun it up and every time I click on a facet I see my search results filtered by that facet. I can do that on a number