Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/805
+1
Followed instructions and everything worked as expected.
Great work @JonZeolla!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/805
never mind, I just re-read the instructions before sorry
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/805
@JonZeolla. Followed the steps, and in my monitor storm logs 'window' i
have many of the following:
```bash
[root@node1 ~]# tail -f
/var/log/storm/workers-artifacts/indexing-*/*/w
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/805
Okay, I just spun up full-dev and followed my testing instructions - all
looks good to me. This is ready for a review.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/805
https://github.com/nickwallen/metron-commit-stuff/blob/master/checkout-pr
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/805
Right @justinleet I've done that in the past as well, this is me just being
lazy and not wanting to look up the PR # when drafting my instructions =)
That said, those instructions don't dep
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/805
It's actually easier than this to pull in a PR, for future reference
```
git fetch upstream pull/805/head:METRON-1261
git checkout METRON-1261
```
Assuming upstream is GitHu
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/805
Maybe we should have the checkout-pr script in the metron repo?
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/805
As usual, I really love your test scripts. Well done, @JonZeolla !
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/805
# Testing
1. Create a working directory and pull in this PR
```
mkdir ~/metron-1261
git clone https://github.com/apache/metron ~/metron-1261/metron
cd ~/metron-12
10 matches
Mail list logo
