[GitHub] metron issue #915: METRON-1433: Only emit debugging timing fields in enrichm...

2018-01-29 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/915 https://github.com/apache/metron/blob/master/metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/EnrichmentJoinBolt.java#L89 ---

[GitHub] metron issue #915: METRON-1433: Only emit debugging timing fields in enrichm...

2018-01-30 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/915 Whoops, missed one. Thanks @mmiklavc ! ---

[GitHub] metron issue #915: METRON-1433: Only emit debugging timing fields in enrichm...

2018-01-30 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/915 +1, lgtm via inspection. ---

[GitHub] metron issue #915: METRON-1433: Only emit debugging timing fields in enrichm...

2018-01-30 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/915 Does anyone anticipate using (or even use) these fields to do things like monitor the flow and latency of their pipelines? I can imagine people wanting to build data quality monitoring repo

[GitHub] metron issue #915: METRON-1433: Only emit debugging timing fields in enrichm...

2018-01-30 Thread mraliagha
Github user mraliagha commented on the issue: https://github.com/apache/metron/pull/915 @simonellistonball We are using threat intel joiner timestamp currently. I am not sure indexing timestamp is added to the latest version or not, but we need the ES indexing one as well. ---

[GitHub] metron issue #915: METRON-1433: Only emit debugging timing fields in enrichm...

2018-01-31 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/915 @mraliagha Well, if it's being used explicitly and on an on-going manner, then I'll remove this PR. Do you think there's some value to being able to slice and dice in the global config the ability

[GitHub] metron issue #915: METRON-1433: Only emit debugging timing fields in enrichm...

2018-01-31 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/915 Perhaps we can leverage parts of the performance logging code for this purpose? The frequency/sampling bit was something I had wanted to add for some time now. https://github.com/apac

[GitHub] metron issue #915: METRON-1433: Only emit debugging timing fields in enrichm...

2018-02-01 Thread mraliagha
Github user mraliagha commented on the issue: https://github.com/apache/metron/pull/915 @cestella Definitely there will be value for having an ability to turn it on and off especially since you have already implemented that. However, won't be a sort of premature disk optimization? We

[GitHub] metron issue #915: METRON-1433: Only emit debugging timing fields in enrichm...

2018-02-05 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/915 @mraliagha Nah, they're not a troublemaker. I'm removing the PR since there's interest in them staying turned on by default. ---