[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

2018-03-09 Thread xyztdanid4
Github user xyztdanid4 commented on the issue: https://github.com/apache/metron/pull/952 @merrimanr As we agreed yesterday I did the required changes in the pom xml-s. I had to update the node dependency of the projects, otherwise the build was failed, cause one of the depende

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

2018-03-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/952 I think we are on board with switching to yarn so no concerns there. There was a discussion on it but if anyone now feels differently, speak up. Sounds like we still have a lot of work to

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

2018-03-07 Thread xyztdanid4
Github user xyztdanid4 commented on the issue: https://github.com/apache/metron/pull/952 @merrimanr although it should work with npm as well, cause then it will use the package.json to install the dependencies. ---

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

2018-03-07 Thread xyztdanid4
Github user xyztdanid4 commented on the issue: https://github.com/apache/metron/pull/952 @merrimanr Yes this is the right way to switch to yarn. Yes we have install yarn locally. I did not know that we have so much dependency on npm. But for me it was hard to add new depen

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

2018-03-07 Thread xyztdanid4
Github user xyztdanid4 commented on the issue: https://github.com/apache/metron/pull/952 @merrimanr ---

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

2018-03-07 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/952 I'm having trouble understanding what this PR actually does. I see that package-lock.json was removed and yarn.lock was added. Is that all that's needed to switch to yarn? Do we need to also upd

[GitHub] metron issue #952: Metron-1480 Add yarn as default build tool for the fronte...

2018-03-07 Thread xyztdanid4
Github user xyztdanid4 commented on the issue: https://github.com/apache/metron/pull/952 @simonellistonball I am not sure. Probably no. ---

[GitHub] metron issue #952: Metron-1480 Add yarn as default build tool for the fronte...

2018-03-07 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/952 Have the dependencies, License and Notices files been updated? ---