Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/858#discussion_r155288298
--- Diff: metron-interface/metron-alerts/e2e/utils/e2e_util.ts ---
@@ -46,25 +48,53 @@ export function waitForStalenessOf (_element
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/858#discussion_r155288566
--- Diff: metron-interface/metron-alerts/pom.xml ---
@@ -130,4 +146,44
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
@merrimanr I'm not sure I understand your steps above, do they run the
tests or is that separate?
What is step 6?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
@merrimanr can you add what directory you should be in when you run the
commands?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
Any chance we can have a discuss on moving other integration tests over?
You mean the regular tests right, like profiler etc?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
So, debugging the integration tests will require having docker running in
the background now?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
I was more thinking about having to have a "Debugging Integration Tests"
readme.
I think having the in-memory stuff available is worth getting some feedback.
I have i
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
Ok, I'm going to try running through some things.
One point, and I will admit this just may be me:
I see the same problem with this as I had with the original docker stuff.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
@merrimanr my protractor config does not have a params entry, so I have
added it as you have it there. Is that usual?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
```bash
metron-alerts configure table
â should select columns from table configuration
- Error: connect ECONNREFUSED 127.0.0.1:9210
- Error: socket hang up
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
No matter what approach we take, my point is that we need to have some
thing that says you need to run docker to debug the tests. Beyond that, we
don't have to over back this. I thin
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
We will, if this pr goes through need to have a 'writing new integration
tests' readme about namespacing etc..
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
@merrimanr That must be it, I didn't do a new pull. Now, to figure out how
to do it with the checkout-pr script and not have to start over.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
OK,
After getting the new changes, everything works as advertised. I was able
to run on mac os , and the end to end passed. I ran a few times in a row and
there where no issues, so it
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
@merrimanr would you imagine someone just leaving this running all the
time? or starting on demand per use?
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/860
METRON-1346 Add new PMC members to site
Add new PMC members @mmiklavc, @justinleet , @ottobackwards
##Testing
Follow steps at
https://cwiki.apache.org/confluence/display/METRON
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/861
Thanks Simon. Before a code review, a couple of questions:
I see a check next to steps to verify manually, but I don't see the steps.
This is also missing documentation.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/861#discussion_r155631654
--- Diff:
metron-platform/metron-common/src/test/java/org/apache/metron/common/field/transformation/SelectTransformationTest.java
---
@@ -0,0 +1,75
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/861#discussion_r155630936
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/field/transformation/SelectTransformation.java
---
@@ -0,0 +1,52
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/861#discussion_r155644387
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -216,6 +216,23 @@ whenever `field2` exists and whose corresponding equal
to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/861#discussion_r155645013
--- Diff:
metron-platform/metron-common/src/test/java/org/apache/metron/common/field/transformation/SelectTransformationTest.java
---
@@ -0,0 +1,75
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/861
That is an excellent catch @simonellistonball, a test to go with it too ;)
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/861#discussion_r155646423
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -216,6 +216,23 @@ whenever `field2` exists and whose corresponding equal
to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/861#discussion_r155648096
--- Diff:
metron-platform/metron-common/src/test/java/org/apache/metron/common/field/transformation/SelectTransformationTest.java
---
@@ -0,0 +1,75
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/861#discussion_r155664254
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -216,6 +216,23 @@ whenever `field2` exists and whose corresponding equal
to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/861#discussion_r155664814
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -216,6 +216,23 @@ whenever `field2` exists and whose corresponding equal
to
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/861
I trying to run this up in full dev. I have two issues:
1. expressJS is failing download, obviously outside this PR
2. The usability of this transform. If a user just wants a
Github user ottobackwards closed the pull request at:
https://github.com/apache/metron/pull/856
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
Bump?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
Closing to test build in travis
---
GitHub user ottobackwards reopened a pull request:
https://github.com/apache/metron/pull/856
METRON-1339 Stellar Shell functionality to verify stored stellar statements
This will allow users to check their deployed statements, say after
upgrade, when they are at rest ( and would
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/861
Sure, that makes sense. I am just trying to wrap my head around why I
would use this based on the data I would send through. I don't have to
understand it for it to be useful ;)
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/861
I ran the following test:
Modified the default snort parser configuration such that it was :
```json
{
"parserClassName":"org.apache.metron.parsers.snort.B
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/861
OK,
Re-ran my scenario after the latest changes, and verified in kibana that
only the msg field was indexed ( except for metron system or added fields ).
+1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
I would be for +1 and landing this pr on the feature branch, then we can
discuss next steps, proposals and start new pr's against FB
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
Maybe a Jira for the feature branch, and each PR as a subtask?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
Similar to https://issues.apache.org/jira/browse/METRON-876
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
I agree with the discuss thread, I'll leave comment on the list for there
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/861
Thank you for the contribution @simonellistonball, please be sure to assign
and close METRON-1341 in jira. Cheers! #ynwa
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/863#discussion_r156372312
--- Diff: metron-platform/metron-indexing/README.md ---
@@ -15,6 +15,12 @@ Indices are written in batch and the batch size and
batch timeout are
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/863#discussion_r156372868
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
---
@@ -229,17 +239,30 @@ public void
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/862
Hi! Thanks for the contribution.
How can we test these changes?
Do we need new tests in the code for this change ?
Please consider the items in the PR checklist ( listed
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/859#discussion_r156374333
--- Diff: metron-deployment/roles/ambari_config/vars/small_cluster.yml ---
@@ -87,6 +87,8 @@ configurations:
topology.classpath
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
@nickwallen any feedback, does the annotated approach match what you
imagined?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/854
based on @justinleet 's comment, where do we stand with this
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/862
Great, can you list that as the manual verification please?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/862
Like,
- Spin up Full Dev
- Go to Swagger at http://node1:4200(?)
- You should see X now
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/853
Does ambari own the application.yaml currently?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/834
Where are we at with this?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/579
@ctramnitz is there any update on this PR? Is there something we can do to
help?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/858
@merrimanr, I have created labels in jira that are applicable to feature
branch Jiras,
This will allow for tracking these jiras in confluence as I have done here
:
https
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/853
What I get to was, the setting should be exposed in ambari if ambari
manages the config.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/834
I expect to address this in the "777" feature branch/ parser effort.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/774
I have created a new feature branch
feature/METRON-1211-extensions-parsers-gradual to track this.
and have rebased this PR on to that.
I have also updated confluence and jira
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/834
I'm good +1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/774
The new Trusty image breaks my build. I need to figure out why exactly, so
I'll be trying a few things.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/863
The minimum required fields, as far as I can see right now are source.type,
original_string and timestamp. Given the use case for this is something that
has skipped the parser topology, we
Github user ottobackwards closed the pull request at:
https://github.com/apache/metron/pull/774
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/865
METRON-1212 The bundle System and Maven Plugin (Feature Branch)
This PR contains the Bundle system and Maven Plugin.
The bundle system and the plugin are adapted from the Apache Nifi
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/862
+1, Thanks for the contribution!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/862
Please take care to mark the jira as done
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/859#discussion_r156737230
--- Diff: metron-deployment/amazon-ec2/README.md ---
@@ -126,6 +126,10 @@ To provision only subsets of the entire Metron
deployment, Ansible tags can
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/866#discussion_r156737918
--- Diff: metron-deployment/playbooks/metron_install.yml ---
@@ -15,13 +15,6 @@
# limitations under the License.
#
---
-- hosts
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/859#discussion_r156751241
--- Diff: metron-deployment/amazon-ec2/README.md ---
@@ -126,6 +126,10 @@ To provision only subsets of the entire Metron
deployment, Ansible tags can
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/859#discussion_r156755792
--- Diff: metron-deployment/amazon-ec2/README.md ---
@@ -126,6 +126,10 @@ To provision only subsets of the entire Metron
deployment, Ansible tags can
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/867#discussion_r156790508
--- Diff:
metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/sampling/SamplingInitFunctions.java
---
@@ -0,0 +1,89
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/867#discussion_r156788055
--- Diff: metron-analytics/metron-statistics/README.md ---
@@ -53,6 +53,32 @@ functions can be used from everywhere where Stellar is
used
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/867#discussion_r156792461
--- Diff: metron-analytics/metron-statistics/README.md ---
@@ -53,6 +53,32 @@ functions can be used from everywhere where Stellar is
used
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/867#discussion_r156792855
--- Diff: metron-analytics/metron-statistics/README.md ---
@@ -53,6 +53,32 @@ functions can be used from everywhere where Stellar is
used
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/867#discussion_r156799548
--- Diff: metron-analytics/metron-statistics/README.md ---
@@ -53,6 +53,32 @@ functions can be used from everywhere where Stellar is
used
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/867#discussion_r156799854
--- Diff:
metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/sampling/UniformSampler.java
---
@@ -0,0 +1,91
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/867#discussion_r156799950
--- Diff:
metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/sampling/UniformSampler.java
---
@@ -0,0 +1,91
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/831
The batch v. hdfs stuff still confuses me, I thought we decided on a
different name?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/866
Do you mean I should see two cowsay building metrons before and only one
after?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/866
How would I have known it was building twice? How do I tell if it builds
only once? I usually fire and forget vagrant up
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/866
i'm on irc if you want to chat btw ;)
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/866
Ok, so validation is through the logs. You mean you don't see cowsay
messages for ansible @nickwallen ? lol
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/866
ok: [node1]
__
< TASK [metron-builder : Build Metron] >
--
\ ^__^
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/866
I am on a mac, and I don't remember why I did it, but I have cowsay
installed
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/867
I'm +1 by inspection, this looks great!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/867
@cestella comments?
https://issues.apache.org/jira/browse/METRON-1361
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/866
Ran per instructions
Ran again with skip tags build
Everything fine in all uis
Nice work! +1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
@nickwallen yeah, we need to cover a bunch a scenarios
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/867
any chance I can see @justinleet 's ideas/prototypes?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/859#discussion_r157048398
--- Diff: metron-deployment/roles/ambari_config/vars/small_cluster.yml ---
@@ -87,6 +87,8 @@ configurations:
topology.classpath
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/859
+1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/868
Is this the first step to a bigger ubuntu story?
Are there follow on PR's lined up or planned for this that add support for
an ubuntu full_dev to test if this works?
Does a
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/869
metron-deployment is really metron deployment and metron packaging. The
packaging part ( which the rpm, deb, mpack, builds really are ) should be
included.
How useful is how to
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/869
maybe some reference to 'future deb instructions to come' ?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/868
That all sounds awesome, and you have obviously done a bunch on this
already, which is super neat. Maybe some list discussion of what you all have
in mind would be appropriate, and help avoid
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/868#discussion_r157086965
--- Diff: metron-deployment/packaging/docker/deb-docker/pom.xml ---
@@ -0,0 +1,253 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmln
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/868#discussion_r157089601
--- Diff: metron-deployment/packaging/docker/deb-docker/pom.xml ---
@@ -0,0 +1,253 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmln
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/868#discussion_r157089695
--- Diff: metron-deployment/packaging/docker/deb-docker/pom.xml ---
@@ -0,0 +1,253 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmln
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/872#discussion_r157332057
--- Diff:
metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/informationtheory/InformationTheoryUtil.java
---
@@ -0,0
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/872#discussion_r157332543
--- Diff:
metron-analytics/metron-statistics/src/main/java/org/apache/metron/statistics/informationtheory/InformationTheoryUtil.java
---
@@ -0,0
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/873
METRON-1367 Stellar should have some instrumentation of function calls
This PR introduces the ability through a new `magic` command for a stellar
shell user to view the timing information for
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/873#discussion_r157377783
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarExecutor.java
---
@@ -289,7 +293,25 @@ public
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/873#discussion_r157377835
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarExecutor.java
---
@@ -289,7 +293,25 @@ public
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/873#discussion_r157377882
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarShell.java
---
@@ -346,6 +348,18 @@ private void
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
One idea for a follow on : add a 'tag' or 'type' similar to log.INFO
log.DEBUG to the records, so that you can filter the output.
---
101 - 200 of 1314 matches
Mail list logo
