[GitHub] incubator-metron pull request: Initial code for a website

Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165457804 I looked at the site, looks much better. I had a couple comments: * I'd drop the "Sample News" and "Welcome to Jekyll" post * Under Develop, I'd add the

[GitHub] incubator-metron pull request: Initial code for a website

Github user ddutta commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165485239 Thx cestella * dropped sample news etc. * the project members and a bunch of other material will be done in another content pull request, there is some ot

[GitHub] incubator-metron pull request: Initial code for a website

Github user ddutta commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165487166 cestella: if you compare with the orc's directory structure, there is a directory called site for the code. Then there is a branch called asf_site where the gener

[GitHub] incubator-metron pull request: Initial code for a website

Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165488150 Right, but if you look what's showing currently in http://metron.incubator.apache.org/, it's the index.html which is at the root of the asf-site branch. Also,

[GitHub] incubator-metron pull request: Initial code for a website

Github user ddutta commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165489127 Yes I need to check the generated files (from the asf_site target) into the asf_site branch of current code base. Then it will auto update. --- If your project

[GitHub] incubator-metron pull request: Initial code for a website

Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165489688 Ahh, I get it. There will be a followup pull request with that patch. Got it. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-metron pull request: Initial code for a website

Github user ddutta commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165491601 Thx for all your feedback hope you can +1 this and merge now. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] incubator-metron pull request: Initial code for a website

Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165492866 I still see the welcome to jekyll post, can you remove it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] incubator-metron pull request: Initial code for a website

Github user ddutta commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165495064 Sorry but where are you seeing the jekyll post ... I did a fresh pull and I am missing it ... my bad. --- If your project is set up for it, you can reply to thi

[GitHub] incubator-metron pull request: Initial code for a website

Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165495993 I just did a clean clone locally and downloaded the patch for the pull request (https://github.com/apache/incubator-metron/pull/1.patch) and applied it (via git

[GitHub] incubator-metron pull request: replace opensoc-streaming version 0...

Github user ptgoetz commented on the pull request: https://github.com/apache/incubator-metron/pull/2#issuecomment-165505353 @james-sirota Here's the process: 1. Add the official Apache repo as a remote in your local clone (one time step): `git remote add apache

[GitHub] incubator-metron pull request: Initial code for a website

Github user ddutta commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165519159 I see it when I apply the patch but can't figure out why my commits are not getting applied to the patch of the pull request. --- If your project is set up for

[GitHub] incubator-metron pull request: Initial code for a website

Github user omalley commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165521885 @cestella the asf-site branch is the output of jekyll. We can have the input to jekyll either in a site directory on the master branch or create a separate branc

[GitHub] incubator-metron pull request: Initial code for a website

Github user ddutta commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165527945 cestella, once this is merged I will clean up the rest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-metron pull request: Initial code for a website

Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165535190 Ok, sounds good. it has my +1 then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] incubator-metron pull request: Initial code for a website

Github user ddutta commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165535355 Thx! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] incubator-metron pull request: Initial code for a website

Github user omalley commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165536229 I'd actually suggest creating a little news item for getting accepted to incubator. --- If your project is set up for it, you can reply to this email and have y

[GitHub] incubator-metron pull request: Initial code for a website

Github user omalley commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165536362 Oh, you can grab the committer list from: http://incubator.apache.org/projects/metron.html --- If your project is set up for it, you can reply to this

[GitHub] incubator-metron pull request: Initial code for a website

Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165549817 Alright, I merged this pull request. This should close automatically. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] incubator-metron pull request: Initial code for a website

Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

dev style

You guys may want to consider using git rebase -i to squash commits together into a single commit as they go into the master. Otherwise your commit history will be relatively noisy. (So the pull request may have 10 commits as it goes through review and iteration, but you want all 10 squashed into a

Re: dev style

Oh that's a good idea. I was following the approach mentioned by Taylor here . Would that git pull command of Taylor's look like git merge g...@github.com:charlesporter/incubator-metron.git master --squash ? Casey On Thu,

Re: dev style

+1 should have done this for my last pull request On Thu, Dec 17, 2015 at 11:23 AM, Casey Stella wrote: > Oh that's a good idea. I was following the approach mentioned by Taylor > here > >. > > Would that git

[GitHub] incubator-metron pull request: Initial code for a website

Github user ddutta commented on the pull request: https://github.com/apache/incubator-metron/pull/1#issuecomment-165566177 Thx! On Thu, Dec 17, 2015 at 11:04 AM, Casey Stella wrote: > Alright, I merged this pull request. This should close automatically. >

[GitHub] incubator-metron pull request: replace opensoc-streaming version 0...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature