[GitHub] incubator-metron pull request: METRON-137: Improve output on ignor...

2016-05-07 Thread dlyle65535
GitHub user dlyle65535 opened a pull request: https://github.com/apache/incubator-metron/pull/110 METRON-137: Improve output on ignored errors. HBase table creation, Kafka topic creation and UI stop will no longer output error text when there is no error. Tested with:

[GitHub] incubator-metron pull request: METRON-140 CSVExtractor gives index...

2016-05-07 Thread jjonez
GitHub user jjonez opened a pull request: https://github.com/apache/incubator-metron/pull/111 METRON-140 CSVExtractor gives index out of bounds error and added test You can merge this pull request into a Git repository by running: $ git pull https://github.com/jjonez/incubator

[GitHub] incubator-metron pull request: METRON-140 CSVExtractor gives index...

2016-05-07 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/111#issuecomment-217664922 Looks like we got 2 for the same JIRA, this PR and PR 109. Cool! It's great when people contribute. :) --- If your project is set up for it, you can reply

[GitHub] incubator-metron pull request: METRON-140 handle empty line in CSV...

2016-05-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/109#discussion_r62421908 --- Diff: metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/extractor/csv/CSVExtractor.java --- @@ -82,6 +83,14 @@

[GitHub] incubator-metron pull request: METRON-140 handle empty line in CSV...

2016-05-07 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/109#discussion_r62421915 --- Diff: metron-platform/metron-data-management/src/test/java/org/apache/metron/dataloads/extractor/csv/CSVExtractorTest.java --- @@ -91,5 +85,9

[GitHub] incubator-metron pull request: METRON-140 handle empty line in CSV...

2016-05-07 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/109#issuecomment-217665302 This looks great outside of the couple of things I mentioned. Definitely like the null check. +1 imminent if you get those changes. --- If your project is

[GitHub] incubator-metron pull request: METRON-137: Improve output on ignor...

2016-05-07 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/110#issuecomment-217665485 Cool, got my vote +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-metron pull request: METRON-138 Update EC2 README

2016-05-07 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/107#issuecomment-217665540 "Having successfully created your Amazon Web Services account, hopefully you will find that the most difficult tasks are behind us." I LOL'd +1 ---

[GitHub] incubator-metron pull request: METRON-140 handle empty line in CSV...

2016-05-07 Thread mmiklavc
Github user mmiklavc commented on the pull request: https://github.com/apache/incubator-metron/pull/109#issuecomment-217666318 I also tested this on single-node Vagrant --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

Metron Person Types...

2016-05-07 Thread John
Hello Dev@Metron, The other day Ryan mentioned that it might be nice to combine the build step (run mvn) before deploying (ex. vagrant up), so people have one less step to type/forget. And he mentioned there might be a jira out there for maybe optionally combining the steps (I'm thinking it's METR