Secure code analysis

2016-05-26 Thread zeo...@gmail.com
I was just wondering if there is any sort of static (or even dynamic) code analysis, or penetrating testing/vulnerability assessment, occurring at any point on the metron code. Has there been any discussion of installing something along those lines on the Travis build server (if it isn't there alr

[GitHub] incubator-metron pull request: METRON-100 GeoIP errors out silentl...

2016-05-26 Thread AromalAS
Github user AromalAS commented on the pull request: https://github.com/apache/incubator-metron/pull/134#issuecomment-221927743 Tested with the latest code changes, ..Good Fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-metron pull request: METRON-100 GeoIP errors out silentl...

2016-05-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/134 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] incubator-metron pull request: METRON-184 Fixed 'creates' path to ...

2016-05-26 Thread nickwallen
Github user nickwallen commented on the pull request: https://github.com/apache/incubator-metron/pull/132#issuecomment-221925530 @dlyle65535 Can you take a look? Any concerns? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-26 Thread nickwallen
Github user nickwallen commented on the pull request: https://github.com/apache/incubator-metron/pull/136#issuecomment-221925290 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] incubator-metron pull request: METRON-180 Enable each component to...

2016-05-26 Thread nickwallen
Github user nickwallen commented on the pull request: https://github.com/apache/incubator-metron/pull/133#issuecomment-221925003 @cestella @mmiklavc Did I answer your question? Any other ways I can make this better? --- If your project is set up for it, you can reply to this email a

[GitHub] incubator-metron pull request: METRON-100 GeoIP errors out silentl...

2016-05-26 Thread nickwallen
Github user nickwallen commented on the pull request: https://github.com/apache/incubator-metron/pull/134#issuecomment-221924679 Good catch. Looks great. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-26 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/136#discussion_r64776627 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/field/transformation/RemoveTransformationTest.java --- @@ -0,0 +1

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-26 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/136#discussion_r64777528 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/field/transformation/RemoveTransformationTest.java --- @@ -0,0 +1

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-26 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/136#discussion_r64777163 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/field/transformation/RemoveTransformationTest.java --- @@ -0,0 +1

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-26 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/136#discussion_r64776535 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/field/transformation/RemoveTransformationTest.java --- @@ -0,0 +1

Re: [GitHub] incubator-metron pull request:

2016-05-26 Thread Nick Allen
It seems like in some cases the dependency is installed as a side-effect or maybe already installed. And in some cases it needs to be installed. I am not sure under which conditions either occurs. It definitely would not hurt to run a `pip install boto` if it happens to already installed. Maybe

[GitHub] incubator-metron pull request: METRON-152: Add support for ES 2.3....

2016-05-26 Thread nickwallen
Github user nickwallen commented on the pull request: https://github.com/apache/incubator-metron/pull/135#issuecomment-221885902 Ran into this error when deploying on Amazon-EC2. Anyone else seeing this? TLDR ``` TypeError: sendall() argument 1 must be string or buffer

[GitHub] incubator-metron pull request: METRON-100 GeoIP errors out silentl...

2016-05-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/134#discussion_r64742580 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/adapters/jdbc/JdbcAdapter.java --- @@ -38,6 +39,27 @@

[GitHub] incubator-metron pull request: METRON-100 GeoIP errors out silentl...

2016-05-26 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/134#discussion_r64741859 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/adapters/jdbc/JdbcAdapter.java --- @@ -38,6 +39,27 @@

[GitHub] incubator-metron pull request: METRON-152: Add support for ES 2.3....

2016-05-26 Thread nickwallen
Github user nickwallen commented on the pull request: https://github.com/apache/incubator-metron/pull/135#issuecomment-221865759 FYI - Spinning up an Amazon deployment on this now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-26 Thread cestella
Github user cestella commented on the pull request: https://github.com/apache/incubator-metron/pull/136#issuecomment-221862988 Yeah, I was thinking about that too. I think transformation is a more descriptive term. You're the 2nd person (in addition to myself) who has made that comm

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-26 Thread nickwallen
Github user nickwallen commented on the pull request: https://github.com/apache/incubator-metron/pull/136#issuecomment-221862663 I am wondering if `mapping` is the most descriptive word we can use here. We are also using map in a lot of different contexts in the configuration that ma

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-26 Thread nickwallen
Github user nickwallen commented on the pull request: https://github.com/apache/incubator-metron/pull/136#issuecomment-221860284 Can you provide some documentation, README or otherwise, on how this will work for a user. Hard to visualize with what you've submitted. What steps do I n

[GitHub] incubator-metron pull request: METRON-186: Create a fieldMapping f...

2016-05-26 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/136#discussion_r64726176 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java --- @@ -61,18 +62,32 @@ public void prepare(