[GitHub] incubator-metron issue #390: METRON-364: Preserve Type for Arithmetic Expres...

Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/390 Cool! Dig the tests. +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-metron issue #390: METRON-364: Preserve Type for Arithmetic Expres...

Github user jjmeyer0 commented on the issue: https://github.com/apache/incubator-metron/pull/390 I believe I have updated all tests and addressed each of the concerns. Thanks again for all the help! --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-metron pull request #390: METRON-364: Preserve Type for Arithmetic...

Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/390#discussion_r91391147 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java --- @@ -56,6 +56,37 @@ public class

[GitHub] incubator-metron pull request #390: METRON-364: Preserve Type for Arithmetic...

Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/390#discussion_r91390855 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java --- @@ -56,6 +56,37 @@ public

[GitHub] incubator-metron pull request #369: METRON-585 Pcap Replay Fails to Stop

Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/369 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-metron pull request #390: METRON-364: Preserve Type for Arithmetic...

Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/390#discussion_r91386719 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java --- @@ -56,6 +56,37 @@ public class

[GitHub] incubator-metron pull request #390: METRON-364: Preserve Type for Arithmetic...

Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/390#discussion_r91386552 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarTest.java --- @@ -56,6 +56,37 @@ public class

[GitHub] incubator-metron issue #390: METRON-364: Preserve Type for Arithmetic Expres...

Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/390 @cestella I see it now, but not when I made the comment. Sorry for adding confusion. +1 by inspection --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-metron issue #390: METRON-364: Preserve Type for Arithmetic Expres...

Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/390 [moving this to unbury it] My only question here, and I may be out of my depth, is does this functionality match the behavior of java itself? Or other languages? Would the result

[GitHub] incubator-metron pull request #390: METRON-364: Preserve Type for Arithmetic...

Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/390#discussion_r91364920 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/stellar/evaluators/ArithmeticEvaluator.java --- @@ -0,0 +1,81

[GitHub] incubator-metron pull request #370: METRON-586 add FILL_LEFT and FILL_RIGHT ...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-metron issue #369: METRON-585 Pcap Replay Fails to Stop

Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/369 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron issue #370: METRON-586 add FILL_LEFT and FILL_RIGHT functio...

Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/370 I am kicking this to travis again. I'm seeing integration test run timeout errors locally trying to verify before commit and I want to sanity check --- If your project is set up

[GitHub] incubator-metron issue #389: METRON-612: Clean up Error Prone generated warn...

Github user ottobackwards commented on the issue: https://github.com/apache/incubator-metron/pull/389 nope, it is fine. I was just thinking that since we are looking outward for reference and inspiration, we should continue to do that on some of these issues as they come up ---

[GitHub] incubator-metron pull request #389: METRON-612: Clean up Error Prone generat...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-metron/pull/389 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-metron issue #370: METRON-586 add FILL_LEFT and FILL_RIGHT functio...

Github user nickwallen commented on the issue: https://github.com/apache/incubator-metron/pull/370 Looks great. Many thanks for the effort. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-metron pull request #364: Metron-580: Remove hard-coded Metron ver...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/364#discussion_r91299872 --- Diff: metron-deployment/packaging/ambari/metron-mpack/pom.xml --- @@ -60,6 +64,19 @@ false

[GitHub] incubator-metron issue #389: METRON-612: Clean up Error Prone generated warn...

Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/389 Totally For Erroring on: SynchronizeOnNonFinalField Not against it for: BoxedPrimitiveConstructor ClassCanBeStatic Okay with it for ClassNewInstance with

[GitHub] incubator-metron issue #390: METRON-364: Preserve Type for Arithmetic Expres...

Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/390 You can return them from as results from stellar functions. Longs are output from time stamp functions for instance. On Wed, Dec 7, 2016 at 08:00 JJ Meyer

[GitHub] incubator-metron issue #390: METRON-364: Preserve Type for Arithmetic Expres...

Github user jjmeyer0 commented on the issue: https://github.com/apache/incubator-metron/pull/390 The reason I neglected longs and floats is because I didn't see the Stellar dsl having the ability to represent them. For example, the test below fails with a parse exception: `

[GitHub] incubator-metron issue #389: METRON-612: Clean up Error Prone generated warn...

Github user dlyle65535 commented on the issue: https://github.com/apache/incubator-metron/pull/389 I'm +1 by inspection. Thanks again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not