Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/404
Thanks @cestella. I appreciate it. If no one has already, I'll work on
those functions we discussed next.
---
If your project is set up for it, you can reply to this email and have your
r
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/404
Yeah, this is good work. I looked at it again after my vacation and I like
it. I give it a +1.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/404
@jjmeyer0 Yeah, I tend to agree. I'll make a follow-on JIRA to add an
`APPROX_EQUALS`. I feel better about it now that we have an `ABS` function.
---
If your project is set up for it, y
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/404
@cestella if comparing floats/doubles is going to be a common thing maybe
we should provide a way to do so easily. Maybe we create functions
FLOAT_EQUALS(f1, f2, epsilon) and DOUBLE_EQUALS
Github user jjmeyer0 commented on the issue:
https://github.com/apache/incubator-metron/pull/404
@cestella I updated the comparison expressions to return false when either
side is null. I'll work on the validation stuff soon.
---
If your project is set up for it, you can reply to th
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/404
One further thought: regarding the validation, I just want to point out
that I'd be ok for validation to not *execute* the statement, but only validate
syntactic correctness and function e
Github user cestella commented on the issue:
https://github.com/apache/incubator-metron/pull/404
Hey, thanks for the great addition @jjmeyer0!
A few things to note and some context.
Around validation, the initial stellar implementation purposefully ran
validation the
