[GitHub] incubator-metron pull request #217: METRON-381: Add support for multiple red...

2016-08-18 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/217 METRON-381: Add support for multiple reducers in pcap_query.sh As a stopgap, the pcap_query.sh MapReduce job uses a single reducer to ensure that the packets captured come in the correct

[GitHub] incubator-metron issue #208: METRON-309 Create a normalcy profiler

2016-08-19 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/208 +1, great job! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron issue #210: METRON-366: Add MODEL_APPLY to Stellar

2016-08-19 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/210 happy to add javadoc to that package. To answer your question, Model and ModelEndpoint are different in the sense that Model is a reference to the model. The ModelEndpoint is a

[GitHub] incubator-metron pull request #210: METRON-366: Add MODEL_APPLY to Stellar

2016-08-19 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/210#discussion_r75533231 --- Diff: metron-analytics/metron-maas-service/src/main/java/org/apache/metron/maas/submit/ModelSubmission.java --- @@ -203,7 +203,7 @@ else if

[GitHub] incubator-metron pull request #210: METRON-366: Add MODEL_APPLY to Stellar

2016-08-19 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/210#discussion_r75533349 --- Diff: metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java --- @@ -93,6 +116,7

[GitHub] incubator-metron pull request #210: METRON-366: Add MODEL_APPLY to Stellar

2016-08-19 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/210#discussion_r75534840 --- Diff: metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java --- @@ -76,12 +92,19

[GitHub] incubator-metron pull request #210: METRON-366: Add MODEL_APPLY to Stellar

2016-08-19 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/210#discussion_r75537367 --- Diff: metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java --- @@ -143,14 +167,59

[GitHub] incubator-metron pull request #210: METRON-366: Add MODEL_APPLY to Stellar

2016-08-19 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/210#discussion_r75539635 --- Diff: metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java --- @@ -40,8 +48,16

[GitHub] incubator-metron pull request #210: METRON-366: Add MODEL_APPLY to Stellar

2016-08-19 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/210#discussion_r75541801 --- Diff: metron-analytics/metron-maas-common/src/main/java/org/apache/metron/maas/discovery/ServiceDiscoverer.java --- @@ -143,14 +167,59

[GitHub] incubator-metron issue #210: METRON-366: Add MODEL_APPLY to Stellar

2016-08-19 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/210 14 minutes?! Woah! @dlyle65535 is my hero. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-metron issue #224: METRON-387 Fix Bad Merge with METRON-309

2016-08-22 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/224 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-metron issue #212: METRON-367 Enhance Profiler to Support Multiple...

2016-08-22 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/212 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron issue #213: METRON-368 Simplify Profile Configuration with ...

2016-08-22 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/213 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron issue #213: METRON-368 Simplify Profile Configuration with ...

2016-08-23 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/213 Yep I took a look last night and just did again. Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-metron pull request #227: METRON-388: Stellar - Unable to Operate ...

2016-08-23 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/227 METRON-388: Stellar - Unable to Operate on Result of If-Then-Else As per [METROn-388](https://issues.apache.org/jira/browse/METRON-388), we added a regression to Stellar around

[GitHub] incubator-metron pull request #225: METRON-372 Enhance Statistical Operation...

2016-08-23 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/225#discussion_r75933182 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/SummaryStatisticsFunctions.java --- @@ -0,0 +1,198

[GitHub] incubator-metron pull request #225: METRON-372 Enhance Statistical Operation...

2016-08-23 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/225#discussion_r75933341 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/SummaryStatisticsFunctions.java --- @@ -0,0 +1,198

[GitHub] incubator-metron pull request #225: METRON-372 Enhance Statistical Operation...

2016-08-23 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/225#discussion_r75933510 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarStatisticalFunctionsTest.java --- @@ -0,0 +1,146

[GitHub] incubator-metron pull request #226: METRON-377 Enable Profiles that Use Non-...

2016-08-23 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/226#discussion_r75933922 --- Diff: metron-platform/metron-common/src/test/java/org/apache/metron/common/stellar/StellarStatisticsFunctionsTest.java --- @@ -0,0 +1,244

[GitHub] incubator-metron pull request #225: METRON-372 Enhance Statistical Operation...

2016-08-23 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/225#discussion_r75934951 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/SummaryStatisticsFunctions.java --- @@ -0,0 +1,198

[GitHub] incubator-metron issue #225: METRON-372 Enhance Statistical Operations Avail...

2016-08-24 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/225 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-metron pull request #228: METRON-390: Stellar functions should ini...

2016-08-24 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/228 METRON-390: Stellar functions should initialize upon use, rather than all at once To test this, you should just spin up the environment in vagrant and everything should work as expected

[GitHub] incubator-metron pull request #228: METRON-390: Stellar functions should ini...

2016-08-24 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/228#discussion_r76098304 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/MaaSFunctions.java --- @@ -234,25 +248,36 @@ public

[GitHub] incubator-metron pull request #228: METRON-390: Stellar functions should ini...

2016-08-24 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/228#discussion_r76098276 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/MaaSFunctions.java --- @@ -188,15 +189,27 @@ public

[GitHub] incubator-metron pull request #226: METRON-377 Enable Profiles that Use Non-...

2016-08-24 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/226#discussion_r76100309 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/StellarStatistics.java --- @@ -0,0 +1,207

[GitHub] incubator-metron pull request #226: METRON-377 Enable Profiles that Use Non-...

2016-08-24 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/226#discussion_r76101432 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/StellarStatistics.java --- @@ -0,0 +1,207

[GitHub] incubator-metron issue #226: METRON-377 Enable Profiles that Use Non-Single ...

2016-08-24 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/226 Looks good, +1 pending green build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-metron pull request #229: METRON-374: Add appropriate bundled 3rd ...

2016-08-24 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/229 METRON-374: Add appropriate bundled 3rd party licenses to NOTICE and LICENSE where appropriate This PR ensures: * Every place where we create a shaded jar, we must add appropriate

[GitHub] incubator-metron issue #218: Metron-383 Create Ambari Service Definition for...

2016-08-25 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/218 +1 pending master is merged in and checks pass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-metron pull request #230: METRON-392 Allow User to Define Custom '...

2016-08-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/230#discussion_r76412457 --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileHBaseMapper.java --- @@ -49,7 +65,7

[GitHub] incubator-metron pull request #230: METRON-392 Allow User to Define Custom '...

2016-08-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/230#discussion_r76412714 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/profiler/ProfileConfig.java --- @@ -27,36 +29,57

[GitHub] incubator-metron pull request #232: METRON-395 Fix Metron Bro parser not par...

2016-08-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/232#discussion_r76413198 --- Diff: metron-platform/metron-integration-test/src/main/sample/data/bro/raw/BroExampleOutput --- @@ -1,10 +1,10 @@ -{"http&

[GitHub] incubator-metron pull request #232: METRON-395 Fix Metron Bro parser not par...

2016-08-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/232#discussion_r76413858 --- Diff: metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/bro/BasicBroParserTest.java --- @@ -46,14 +46,37 @@ public

[GitHub] incubator-metron pull request #232: METRON-395 Fix Metron Bro parser not par...

2016-08-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/232#discussion_r76413970 --- Diff: metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bro/BasicBroParser.java --- @@ -34,6 +35,7

[GitHub] incubator-metron pull request #232: METRON-395 Fix Metron Bro parser not par...

2016-08-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/232#discussion_r76414283 --- Diff: metron-platform/metron-integration-test/src/main/sample/data/bro/parsed/BroExampleParsed --- @@ -1,10 +1,10 @@ -{"bro_time

[GitHub] incubator-metron pull request #231: METRON-394 Create Stellar Date Functions...

2016-08-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/231#discussion_r76414651 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/DateFunctions.java --- @@ -114,17 +122,176 @@ public

[GitHub] incubator-metron issue #231: METRON-394 Create Stellar Date Functions to Use...

2016-08-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/231 Looks good, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron pull request #231: METRON-394 Create Stellar Date Functions...

2016-08-26 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/231#discussion_r76414698 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/DateFunctions.java --- @@ -114,17 +122,176 @@ public

[GitHub] incubator-metron issue #218: Metron-383 Create Ambari Service Definition for...

2016-08-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/218 This looks good; I'll go +1 providing @dlyle65535 will +1 with me as I'm no expert in Ambari. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] incubator-metron pull request #233: METRON-396: Make Stellar function resolu...

2016-08-26 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/233 METRON-396: Make Stellar function resolution happen via an annotation and classpath search At the moment, the only way to add a stellar function is to implement StellarFunction and add

[GitHub] incubator-metron issue #232: METRON-395 Fix Metron Bro parser not parsing so...

2016-08-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/232 +1, this looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron issue #233: METRON-396: Make Stellar function resolution ha...

2016-08-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/233 Ok, this should be a transparent change to the topology. Things should continue to function as expected. I also verified that this did not break pcap's `query` filter. As

[GitHub] incubator-metron issue #232: METRON-395 Fix Metron Bro parser not parsing so...

2016-08-26 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/232 So, @mmiklavc this is failing under travis, but the failure that I saw generally is due to travis being overwhelmed and one of the integration test components (kafka in this case, I

[GitHub] incubator-metron pull request #234: METRON-397: Add a stellar function to in...

2016-08-27 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/234 METRON-397: Add a stellar function to interact with the HBase enrichment table We currently can only do simple HBase enrichment and threat intel via specialized adapters. With the

[GitHub] incubator-metron pull request #233: METRON-396: Make Stellar function resolu...

2016-08-30 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/233#discussion_r76918935 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/FunctionResolverSingleton.java --- @@ -0,0 +1,206

[GitHub] incubator-metron issue #239: METRON-401 ParseException Thrown by ThreatIntel...

2016-08-31 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/239 +1 pending travis checks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron pull request #233: METRON-396: Make Stellar function resolu...

2016-08-31 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/233#discussion_r77121424 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/FunctionResolverSingleton.java --- @@ -0,0 +1,206

[GitHub] incubator-metron issue #233: METRON-396: Make Stellar function resolution ha...

2016-09-02 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/233 Yeah getting to that; in a bit of a Internet connection blackhole On Fri, Sep 2, 2016 at 07:43 Nick Allen wrote: > FYI - Your branch needs merged with master before we

[GitHub] incubator-metron issue #233: METRON-396: Make Stellar function resolution ha...

2016-09-02 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/233 Ok, merged master in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #241: METRON-400 Deploy Probes to running Docker Cont...

2016-09-04 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/241 +1 by inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron issue #230: METRON-392 Allow User to Define Custom 'Group B...

2016-09-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/230 +1, looks good post master merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron issue #241: METRON-400 Deploy Probes to running Docker Cont...

2016-09-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/241 @nickwallen The failing test in the profiler appears to be intermittent. It hit me once earlier and I couldn't recreate it, would you please take a look? --- If your project is s

[GitHub] incubator-metron issue #240: METRON-404 Stellar Compiler Hides Function Init...

2016-09-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/240 +1, love it. Pissed me off too. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-metron pull request #243: METRON-406: Stellar variable resolution ...

2016-09-06 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/243 METRON-406: Stellar variable resolution does not resolve variables with ':' in them This is entirely tested via unit tests at the moment. I will spin up a vagrant box to

[GitHub] incubator-metron pull request #244: METRON-407: We currently do not provide ...

2016-09-06 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/244 METRON-407: We currently do not provide defaults if the Stix Observable does not specify a condition When manually creating indicators in Soltra, the condition for the observable is not

[GitHub] incubator-metron issue #244: METRON-407: We currently do not provide default...

2016-09-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/244 Just for posterity, from [here](http://stixproject.github.io/documentation/suggested-practices/) justifying considering an absence of a condition to be an equality condition

[GitHub] incubator-metron issue #241: METRON-400 Deploy Probes to running Docker Cont...

2016-09-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/241 Well, this branch does not have #233 merged in and it's failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-metron issue #233: METRON-396: Make Stellar function resolution ha...

2016-09-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/233 Yeah, I see what you're saying; that's a good catch. You are doing some testing for initialization and you want to uninitialize. One thing we could do is provide a funct

[GitHub] incubator-metron issue #241: METRON-400 Deploy Probes to running Docker Cont...

2016-09-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/241 So, one solution would be to try to read the configurations back out of zookeeper in the ConfigUploadComponent.start() in a loop until you can read them back (with a sleep between the

[GitHub] incubator-metron issue #241: METRON-400 Deploy Probes to running Docker Cont...

2016-09-06 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/241 I will admit to being quite confused as to why the EnrichmentIntegrationTest is not intermittently failing or any of the ParserIntegrationTests, considering they should have this same

[GitHub] incubator-metron issue #245: METRON-408 Intermittent Failures of Profile Int...

2016-09-07 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/245 Looks good, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron issue #234: METRON-397: Add a stellar function to interact ...

2016-09-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/234 The AccessTracker allows us to track which keys in the hbase table are accessed. This is so that pruning an be done based on most current usage. It is used in the exisiting HBase

[GitHub] incubator-metron issue #234: METRON-397: Add a stellar function to interact ...

2016-09-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/234 @nickwallen This is tested as part of the enrichment integration tests, but I will add a unit test for the specific function as well. --- If your project is set up for it, you can reply

[GitHub] incubator-metron pull request #236: METRON-389 Create Java API to Read Profi...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/236#discussion_r78367857 --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java --- @@ -100,7 +101,11 @@ public

[GitHub] incubator-metron pull request #236: METRON-389 Create Java API to Read Profi...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/236#discussion_r78368076 --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java --- @@ -194,8 +194,8 @@ private

[GitHub] incubator-metron pull request #236: METRON-389 Create Java API to Read Profi...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/236#discussion_r78369111 --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/hbase/SaltyRowKeyBuilder.java --- @@ -0,0 +1,211

[GitHub] incubator-metron pull request #236: METRON-389 Create Java API to Read Profi...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/236#discussion_r78369359 --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/hbase/Serializer.java --- @@ -0,0 +1,92

[GitHub] incubator-metron pull request #236: METRON-389 Create Java API to Read Profi...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/236#discussion_r78370176 --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/bolt/ProfileBuilderBolt.java --- @@ -194,8 +194,8 @@ private

[GitHub] incubator-metron issue #237: METRON-399 Stellar Date Functions Should Defaul...

2016-09-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/237 +1, good stuff --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-metron pull request #236: METRON-389 Create Java API to Read Profi...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/236#discussion_r78371624 --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/hbase/SaltyRowKeyBuilder.java --- @@ -0,0 +1,211

[GitHub] incubator-metron pull request #236: METRON-389 Create Java API to Read Profi...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/236#discussion_r78374098 --- Diff: metron-analytics/metron-profiler/src/main/java/org/apache/metron/profiler/hbase/Serializer.java --- @@ -0,0 +1,92

[GitHub] incubator-metron issue #236: METRON-389 Create Java API to Read Profile Data...

2016-09-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/236 Ok, I think I'm +1 on this pending the two JIRAs mentioned from the review: * Adjust `ProfilerClient` to add a method that takes a start/end time method. * Chang

[GitHub] incubator-metron pull request #242: METRON-391 Create Stellar Function to Re...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/242#discussion_r78421803 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -0,0 +1,179

[GitHub] incubator-metron issue #242: METRON-391 Create Stellar Function to Read Prof...

2016-09-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/242 It appears that these functions require a number of capabilities (profiler hbase table, etc) that are not setup by default in the parser or enrichment topology. Have you tested calling

[GitHub] incubator-metron pull request #242: METRON-391 Create Stellar Function to Re...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/242#discussion_r78424147 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -0,0 +1,179

[GitHub] incubator-metron pull request #242: METRON-391 Create Stellar Function to Re...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/242#discussion_r78424348 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -0,0 +1,179

[GitHub] incubator-metron issue #242: METRON-391 Create Stellar Function to Read Prof...

2016-09-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/242 @nickwallen Yeah, that's why I don't want to treat these as capabilities, but rather pull them from the global configs. The function should configure itself from the global c

[GitHub] incubator-metron issue #248: METRON-414: Kibana Ansible Install Fails with S...

2016-09-12 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/248 +1, pending travis build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron pull request #242: METRON-391 Create Stellar Function to Re...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/242#discussion_r78433046 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -0,0 +1,179

[GitHub] incubator-metron pull request #242: METRON-391 Create Stellar Function to Re...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/242#discussion_r78433288 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -0,0 +1,179

[GitHub] incubator-metron pull request #242: METRON-391 Create Stellar Function to Re...

2016-09-12 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/242#discussion_r78434213 --- Diff: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/stellar/GetProfile.java --- @@ -0,0 +1,179

[GitHub] incubator-metron issue #242: METRON-391 Create Stellar Function to Read Prof...

2016-09-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/242 Agreed, however in this case and in every case I can think of as a stellar function writer, you should use the configs from zookeeper to configure your function. --- If your project is

[GitHub] incubator-metron issue #234: METRON-397: Add a stellar function to interact ...

2016-09-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/234 @nickwallen Thanks for the feedback. I'm going to disagree heartily that we should spend much time constructing javadocs for an API that is extremely fluid and changing. To p

[GitHub] incubator-metron pull request #250: METRON-416: Provide the ability to store...

2016-09-13 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/250 METRON-416: Provide the ability to store mergeable data structures for summarizing data on-line With the currently worked on profiler, we it will be advantageous for us to be able to

[GitHub] incubator-metron issue #242: METRON-391 Create Stellar Function to Read Prof...

2016-09-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/242 +1, looks good. I'll tackle METRON-415 to expand this to non-numeric data. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-metron pull request #250: METRON-416: Provide the ability to store...

2016-09-13 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/250#discussion_r78632699 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/math/stats/OnlineStatisticsProvider.java --- @@ -0,0 +1,243

[GitHub] incubator-metron issue #250: METRON-416: Provide the ability to store mergea...

2016-09-13 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/250 Done, thanks for the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-metron issue #250: METRON-416: Provide the ability to store mergea...

2016-09-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/250 Agree, both of them are irritating and now fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] incubator-metron issue #246: METRON-411 Support Greater Range of Profile Per...

2016-09-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/246 Could you please walk us through a test plan of how this feature should be exercised in quickdev? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-metron issue #246: METRON-411 Support Greater Range of Profile Per...

2016-09-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/246 Cool, looks great. Much cleaner. :) +1 if you tested in vagrant already. If not, then I'll hold the +1 til you let me know. --- If your project is set up for it, you can

[GitHub] incubator-metron issue #250: METRON-416: Provide the ability to store mergea...

2016-09-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/250 Validated on Vagrant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-metron issue #246: METRON-411 Support Greater Range of Profile Per...

2016-09-14 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/246 I'm specifically interested in making sure that you can call the stellar functions around the profiler from within the enrichment topology on vagrant, actually. I may be missing it

[GitHub] incubator-metron issue #246: METRON-411 Support Greater Range of Profile Per...

2016-09-15 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/246 That sounds fair. +1 as long as in that follow-on PR gets created and prioritized. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-metron pull request #253: METRON-415: Allow a Profile to Store Any...

2016-09-15 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/253 METRON-415: Allow a Profile to Store Any Type as its Value The profiler currently only supports profile's with one of the following numeric types; Integer, Short, Long, Double, or

[GitHub] incubator-metron pull request #251: METRON-418 Set TTL on HBase Puts

2016-09-15 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/251#discussion_r78999765 --- Diff: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/ProfileWriter.java --- @@ -92,8 +92,8

[GitHub] incubator-metron issue #251: METRON-418 Set TTL on HBase Puts

2016-09-15 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/251 I'm betting travis is overloaded, try closing and reopening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-metron pull request #251: METRON-418 Set TTL on HBase Puts

2016-09-15 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/251#discussion_r79014810 --- Diff: metron-analytics/metron-profiler-client/src/test/java/org/apache/metron/profiler/client/ProfileWriter.java --- @@ -92,8 +92,8

[GitHub] incubator-metron issue #251: METRON-418 Set TTL on HBase Puts

2016-09-15 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/251 This looks good; I'm +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] incubator-metron pull request #255: METRON-422: Remove bluecoat.json

2016-09-15 Thread cestella
GitHub user cestella opened a pull request: https://github.com/apache/incubator-metron/pull/255 METRON-422: Remove bluecoat.json title says it all. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cestella/incubator-metron METRON

[GitHub] incubator-metron issue #256: Metron 257 Enable pcap result pagination from t...

2016-09-16 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/256 It's troubling because that RNG is seeded and the results should be deterministic. I wonder if the t-digest merge has some non-determinism. Anyway, it needs to be fixed, but defin

<    3   4   5   6   7   8   9   10   11   12   >