Re: Is the ExceptionMonitor usefull ?

2008-07-12 Thread peter royal
On Jul 7, 2008, at 2:30 PM, Niklas Gustavsson wrote: @Override public void exceptionCaught(Throwable cause) { -if (log.isWarnEnabled()) { +if (cause instanceof Error) { +throw (Error) cause; +} else { log.warn("Unexpected exception.", cause)

Re: MINA 1.1.7 MD5 and SHA1 hashes do not match downloads

2008-07-12 Thread Niklas Gustavsson
On Fri, Jul 11, 2008 at 10:37 PM, Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: > Yes, they have to be in sync. Make me realize that I didn't added my key in > this file :) I've updated the KEYS file in www.apache.org/dist/mina and added a note to the file to remind future updaters to do the same.

[jira] Created: (FTPSERVER-139) Include connection management settings in the Spring config

2008-07-12 Thread Niklas Gustavsson (JIRA)
Include connection management settings in the Spring config --- Key: FTPSERVER-139 URL: https://issues.apache.org/jira/browse/FTPSERVER-139 Project: FtpServer Issue Type: Improvement

Setting scope for test dependencies

2008-07-12 Thread Niklas Gustavsson
Hi We do not currently set the scope of test dependencies in the POM. This has the huge negative effect of MINA dragging in stuff like easy mock in downstream projects. I propose the following change: Index: core/pom.xml === --- core

Heads up: major breaking changes in FtpServer

2008-07-12 Thread Niklas Gustavsson
Hi I'm in the process of updating FtpServer trunk to default to using the new configuration. As a major step, I today commited a few changes that make the scripts provided in the distribution using the new format. That means that if you're tracking trunk and use these scripts, you have to migrate

Re: Setting scope for test dependencies

2008-07-12 Thread W.B. Garvelink
+1 On Sat, Jul 12, 2008 at 11:20 PM, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > Hi > > We do not currently set the scope of test dependencies in the POM. > This has the huge negative effect of MINA dragging in stuff like easy > mock in downstream projects. I propose the following change: >

Re: Setting scope for test dependencies

2008-07-12 Thread Emmanuel Lecharny
Niklas Gustavsson wrote: Hi We do not currently set the scope of test dependencies in the POM. This has the huge negative effect of MINA dragging in stuff like easy mock in downstream projects. I propose the following change: Index: core/pom.xml =

Re: Setting scope for test dependencies

2008-07-12 Thread Alex Karasulu
Big +1 On Sat, Jul 12, 2008 at 5:20 PM, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > Hi > > We do not currently set the scope of test dependencies in the POM. > This has the huge negative effect of MINA dragging in stuff like easy > mock in downstream projects. I propose the following change: >

Re: Setting scope for test dependencies

2008-07-12 Thread Niklas Gustavsson
On Sun, Jul 13, 2008 at 1:21 AM, Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: >> Another option is to leave this out of dependencyManagement and >> declare it in the concrete POMs. What do you think? > > Using scope is better than declare the needed versionss in each pom, IMHO. We can still use de