Re: Re : svn commit: r685401 - /mina/trunk/core/pom.xml

2008-08-13 Thread Emmanuel Lecharny
Edouard De Oliveira wrote: Hi guys, +1 to dependency discussion. I didn't know we could just add some apache class in in order to avoid adding dependencies to the core. In fact, the code used the class and i thought it was preferable to import the dependency to avoid code dup so i modified it j

Re: Re : svn commit: r685401 - /mina/trunk/core/pom.xml

2008-08-13 Thread Niklas Gustavsson
On Wed, Aug 13, 2008 at 8:54 AM, Edouard De Oliveira <[EMAIL PROTECTED]> wrote: > Talking abouts this, i'm relatively new to maven but parent pom already > enlists commons-codec as a dependency > why do the core child pom can't beneficiate from this dependency ? It's declared in the parent pom wi

Re: Re : svn commit: r685401 - /mina/trunk/core/pom.xml

2008-08-13 Thread Julien Vermillard
Hi, Well dependencies of a lib is always a hot subject, not as big as logging, but it is :) We can't introduce a new dep without consensus, or the angry mob will lynch us. I think common-codec is used nowhere, it's probably a mistake if it's still in parent pom.xml. As Emm know it's a PITA to java

Commons Codec Base64 Was : Re: Re : svn commit: r685401 - /mina/trunk/core/pom.xml

2008-08-13 Thread Julien Vermillard
On Wed, 13 Aug 2008 06:54:29 + (GMT) Edouard De Oliveira <[EMAIL PROTECTED]> wrote: > Hi guys, > +1 to dependency discussion. I didn't know we could just add some > apache class in in order to avoid adding dependencies to the core. In > fact, the code used the class and i thought it was prefer

[jira] Created: (FTPSERVER-153) XML config local-address element does not set server address correctly

2008-08-13 Thread Niklas Gustavsson (JIRA)
XML config local-address element does not set server address correctly -- Key: FTPSERVER-153 URL: https://issues.apache.org/jira/browse/FTPSERVER-153 Project: FtpServer Issu

[jira] Closed: (FTPSERVER-153) XML config local-address element does not set server address correctly

2008-08-13 Thread Niklas Gustavsson (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Gustavsson closed FTPSERVER-153. --- Resolution: Fixed Fixed and test added. XML schema unchanged, setting local-addres

[jira] Assigned: (DIRMINA-616) New release.xml file

2008-08-13 Thread Julien Vermillard (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Vermillard reassigned DIRMINA-616: - Assignee: Julien Vermillard > New release.xml file > > >

[jira] Commented: (DIRMINA-616) New release.xml file

2008-08-13 Thread Julien Vermillard (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622206#action_12622206 ] Julien Vermillard commented on DIRMINA-616: --- looks good but the multiple files i

[jira] Created: (FTPSERVER-154) Do not allow AUTH on an already secured session

2008-08-13 Thread Niklas Gustavsson (JIRA)
Do not allow AUTH on an already secured session --- Key: FTPSERVER-154 URL: https://issues.apache.org/jira/browse/FTPSERVER-154 Project: FtpServer Issue Type: Bug Components: Core Aff

[jira] Closed: (FTPSERVER-154) Do not allow AUTH on an already secured session

2008-08-13 Thread Niklas Gustavsson (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Gustavsson closed FTPSERVER-154. --- Resolution: Fixed Fixed, we now return 534 on a reissued AUTH svn commit "/media/

[jira] Closed: (FTPSERVER-151) getClientCertificates does not work in explicit mode

2008-08-13 Thread Niklas Gustavsson (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Gustavsson closed FTPSERVER-151. --- Resolution: Fixed Fixed and test added svn commit "/media/big/home/svn/apache/ftp

[jira] Updated: (FTPSERVER-152) NativeFileObject.hasDeletePermission() not working as expected.

2008-08-13 Thread Niklas Gustavsson (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Gustavsson updated FTPSERVER-152: Fix Version/s: (was: 1.0-M2) 1.0-M3 A

[jira] Closed: (FTPSERVER-149) Provide convenience methods for checking is the control and data sockets are secure

2008-08-13 Thread Niklas Gustavsson (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niklas Gustavsson closed FTPSERVER-149. --- Resolution: Fixed Fixed, again :-) svn commit "/media/big/home/svn/apache/ftpserv

[jira] Commented: (FTPSERVER-152) NativeFileObject.hasDeletePermission() not working as expected.

2008-08-13 Thread Niklas Gustavsson (JIRA)
[ https://issues.apache.org/jira/browse/FTPSERVER-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622330#action_12622330 ] Niklas Gustavsson commented on FTPSERVER-152: - Could you please add some tes

Re : Commons Codec Base64 Was : Re: Re : svn commit: r685401 - /mina/trunk/core/pom.xml

2008-08-13 Thread Edouard De Oliveira
Quote from commons-codec web site : "Codec was formed as an attempt to focus development effort on one definitive implementation of the Base64 encoder. At the time of Codec's proposal, there were approximately 34 different Java classes that dealt with Base64 encoding spread over the Foundation's

Re: Re : Commons Codec Base64 Was : Re: Re : svn commit: r685401 - /mina/trunk/core/pom.xml

2008-08-13 Thread Emmanuel Lecharny
Edouard De Oliveira wrote: I know that having a core that do not rely on some other lib is a good feature. But is code dup worth it ? I personnaly hate it but i'm not saying we absolutely should avoid it specially when we're talking about only one class ... Well, we have to balance advantag

Re : svn commit: r685389 [4/4] - in /mina/trunk/core/src/main/java/org/apache/mina/proxy: ./ event/ filter/ handlers/ handlers/http/ handlers/http/basic/ handlers/http/digest/ handlers/http/ntlm/ hand

2008-08-13 Thread Edouard De Oliveira
Hi, the author tags have been fixed but i have now some questions about licensing : o.a.m.proxy.utils.StringUtilities.java & o.a.m.proxy.handlers.http.digest.DigestUtilities.java have been written by using some code borrowed from Mailster which is a project that i develop alone using a GPL 2.0.

Re: Re : svn commit: r685389 [4/4] - in /mina/trunk/core/src/main/java/org/apache/mina/proxy: ./ event/ filter/ handlers/ handlers/http/ handlers/http/basic/ handlers/http/digest/ handlers/http/ntlm/

2008-08-13 Thread Julien Vermillard
On Thu, 14 Aug 2008 00:31:17 + (GMT) Edouard De Oliveira <[EMAIL PROTECTED]> wrote: > Hi, the author tags have been fixed but i have now some questions > about licensing : o.a.m.proxy.utils.StringUtilities.java & > o.a.m.proxy.handlers.http.digest.DigestUtilities.java have been > written by us

Re: Re : Commons Codec Base64 Was : Re: Re : svn commit: r685401 - /mina/trunk/core/pom.xml

2008-08-13 Thread Julien Vermillard
On Thu, 14 Aug 2008 01:04:02 +0200 Emmanuel Lecharny <[EMAIL PROTECTED]> wrote: > Edouard De Oliveira wrote: > > > > I know that having a core that do not rely on some other lib is a > > good feature. But is code dup worth it ? I personnaly hate it but > > i'm not saying we absolutely should avo