Re: [MINA 3.0] filter chains

2011-08-19 Thread Alan D. Cabrera
On Aug 19, 2011, at 4:16 AM, Julien Vermillard wrote: Hi, I implemented some really simple chain for MINA 3 based on a list of chain processed by a filter chain. The implementation is very simple, sounded like a good idea :

IoBuffers of bytebuffers

2011-08-19 Thread Alan D. Cabrera
I'm wondering. Do you guys think it's a good idea? It seems to make things pretty complicated and adds another dimension to groking the behavior of your service. I'm not sure that it's necessary. Thoughts? Regards, Alan

Re: [MINA 3.0] filter chains

2011-08-19 Thread Emmanuel Lecharny
On 8/19/11 1:55 PM, Alan D. Cabrera wrote: On Aug 19, 2011, at 4:16 AM, Julien Vermillard wrote: Hi, I implemented some really simple chain for MINA 3 based on a list of chain processed by a filter chain. The implementation is very simple, sounded like a good idea :

Re: IoBuffers of bytebuffers

2011-08-19 Thread Emmanuel Lecharny
On 8/19/11 2:16 PM, Alan D. Cabrera wrote: I'm wondering. Do you guys think it's a good idea? It seems to make things pretty complicated and adds another dimension to groking the behavior of your service. I'm not sure that it's necessary. Definitively a bad idea. What we need is an

Re: IoBuffers of bytebuffers

2011-08-19 Thread Alan D. Cabrera
On Aug 19, 2011, at 5:19 AM, Emmanuel Lecharny wrote: On 8/19/11 2:16 PM, Alan D. Cabrera wrote: I'm wondering. Do you guys think it's a good idea? It seems to make things pretty complicated and adds another dimension to groking the behavior of your service. I'm not sure that it's

Re: [MINA 3.0] filter chains

2011-08-19 Thread Alan D. Cabrera
On Aug 19, 2011, at 5:16 AM, Emmanuel Lecharny wrote: On 8/19/11 1:55 PM, Alan D. Cabrera wrote: On Aug 19, 2011, at 4:16 AM, Julien Vermillard wrote: Hi, I implemented some really simple chain for MINA 3 based on a list of chain processed by a filter chain. The implementation is very

AW: [MINA 3.0] filter chains

2011-08-19 Thread Steve Ulrich
Hi! Besides the points you mentioned, there are some other flaws: 1) How do you handle post-message-forwarding logic? 2) How do you handle filters that transparently push messages to the underlying filters (e.g. keep alive)? So the filters should decide about what to do, the chain about the

Re: [MINA 3.0] filter chains

2011-08-19 Thread Julien Vermillard
I half implemented the controller idea, it's looking like working, I'll finish that during the weekend or next week and commit it for review. Julien On Fri, Aug 19, 2011 at 2:39 PM, Steve Ulrich steve.ulr...@proemion.com wrote: Hi! Besides the points you mentioned, there are some other flaws:

RE: IoBuffers of bytebuffers

2011-08-19 Thread Steve Ulrich
Alan D. Cabrera [mailto:l...@toolazydogs.com] wrote: So, what is the scenario that we're trying to support? I imagine appending headers to binary data would be one. In this case is an Array of ByteBuffers really needed? Why not just send down one ByteBuffer for the header and another for

Re: IoBuffers of bytebuffers

2011-08-19 Thread Julien Vermillard
On Fri, Aug 19, 2011 at 3:51 PM, Steve Ulrich steve.ulr...@proemion.com wrote: Alan D. Cabrera [mailto:l...@toolazydogs.com] wrote: So, what is the scenario that we're trying to support?  I imagine appending headers to binary data would be one.  In this case is an Array of ByteBuffers really

Re: [MINA 3.0] filter chains

2011-08-19 Thread Julien Vermillard
Ok I committed the modification, for passing a chain controller to the filter for delegating the call to next filter. First I did it only for read write chaining because the other events (created,open,closed,idle) are fine like they are. They don't need to block an event or send it multiple time

Re: [MINA 3.0] filter chains

2011-08-19 Thread Alan D. Cabrera
Why do we pass the current position? We also seem to pass it twice in the method and the controller. Regards, Alan On Aug 19, 2011, at 1:10 PM, Julien Vermillard wrote: Ok I committed the modification, for passing a chain controller to the filter for delegating the call to next filter.

Re: IoBuffers of bytebuffers

2011-08-19 Thread Emmanuel Lecharny
On 8/19/11 2:26 PM, Alan D. Cabrera wrote: On Aug 19, 2011, at 5:19 AM, Emmanuel Lecharny wrote: On 8/19/11 2:16 PM, Alan D. Cabrera wrote: I'm wondering. Do you guys think it's a good idea? It seems to make things pretty complicated and adds another dimension to groking the behavior of

Re: [MINA 3.0] filter chains

2011-08-19 Thread Emmanuel Lecharny
On 8/19/11 2:29 PM, Alan D. Cabrera wrote: On Aug 19, 2011, at 5:16 AM, Emmanuel Lecharny wrote: On 8/19/11 1:55 PM, Alan D. Cabrera wrote: On Aug 19, 2011, at 4:16 AM, Julien Vermillard wrote: Hi, I implemented some really simple chain for MINA 3 based on a list of chain processed by a