Re: [MINA 3] SSL working session : a feedback

2013-05-06 Thread Jeff MAURY
Emmanuel, that's a good resume of what we discussed yesterday but I'd like to add the following: 1) Events The sessionOpened event is generated when the socket is created, should we defer it until the handshake is completed ? And as we now support rehandshaking, what do we do when the

Re: [MINA 3] SSL working session : a feedback

2013-05-06 Thread Emmanuel Lécharny
Le 5/6/13 10:05 AM, Jeff MAURY a écrit : Emmanuel, that's a good resume of what we discussed yesterday but I'd like to add the following: 1) Events The sessionOpened event is generated when the socket is created, should we defer it until the handshake is completed ? I don't think so.

Re: [MINA 3] SSL working session : a feedback

2013-05-06 Thread Emmanuel Lécharny
Jean-François, in the SslHelper class, processRead method, line 241, you check the numbe rof produced bytes, and you call the processMessageReceived() method if it's not zero. I think we should call the processMessageReceived() even if ther eis zero bytes produced, accordingly to the

Re: [MINA 3] SSL working session : a feedback

2013-05-06 Thread Emmanuel Lécharny
Jean-François, one interesting piece of information from the RFC : 7.1 : ... Note: If a rehandshake occurs while data is flowing on a connection, the communicating parties may continue to send data using the old CipherSpec. However, once the ChangeCipherSpec has been sent, the new CipherSpec

Re: [MINA 3] SSL working session : a feedback

2013-05-06 Thread Jeff MAURY
Agree with that. So we probably need a flag to tell do not encrypt that will also be used for handshake messages. Regards Jeff On Mon, May 6, 2013 at 5:31 PM, Emmanuel Lécharny elecha...@gmail.comwrote: Jean-François, one interesting piece of information from the RFC : 7.1 : ... Note: