Re: MINA 3.0 JDK7+ only ?

2013-05-20 Thread Emmanuel Lécharny
Le 5/20/13 8:36 AM, Julien Vermillard a écrit : > Hi ! > > Would it cause problems for having MINA 3 jdk7 only ? > The rational is quite simple : multicast udp support is only in jdk7. > > I know a lot of people are still running jdk6 or event 5 :) that's why I ask. Java 6 is EOL since last year. H

Re: MINA 3.0 JDK7+ only ?

2013-05-20 Thread Julien Vermillard
The idea of being 7 only is to avoid that ;) On Mon, May 20, 2013 at 9:15 AM, Emmanuel Lécharny wrote: > Le 5/20/13 8:36 AM, Julien Vermillard a écrit : >> Hi ! >> >> Would it cause problems for having MINA 3 jdk7 only ? >> The rational is quite simple : multicast udp support is only in jdk7. >>

Re: Sonar

2013-05-20 Thread Emmanuel Lécharny
Le 5/19/13 11:18 PM, Raphaël Barazzutti a écrit : > Hi all! Hi Raphaël ! > > I'm currently working fixing some issues in the delimited module of codec > and the serialization modules. > > Currently some lines in my codes are generating warnings in Sonar. You are not alone here :) I fixed many wa

Re: Sonar

2013-05-20 Thread Julien Vermillard
Hi, comments inline On Mon, May 20, 2013 at 10:59 AM, Emmanuel Lécharny wrote: > Le 5/19/13 11:18 PM, Raphaël Barazzutti a écrit : >> >> I'm currently working fixing some issues in the delimited module of codec >> and the serialization modules. >> >> Currently some lines in my codes are generating

Dubious code in SslHelper...

2013-05-20 Thread Emmanuel Lécharny
Hi guys, in SslHelper, we do have some code that unwrap the incoming data : private void processUnwrap(AbstractIoSession session, ByteBuffer inBuffer) throws SSLException { // Blind guess : once uncompressed, the resulting buffer will be 3 times bigger ByteBuffer appBuffer = B

Re: MINA 3.0 JDK7+ only ?

2013-05-20 Thread Raphaël Barazzutti
IMHO, developers who will do the jump to MINA 3.0, might also want to benefit of the cutting-edge features of JDK7. +1 for MINA 3.0 on JDK7 On Mon, May 20, 2013 at 9:39 AM, Julien Vermillard wrote: > The idea of being 7 only is to avoid that ;) > > > On Mon, May 20, 2013 at 9:15 AM, Emmanuel Léc

Re: Sonar

2013-05-20 Thread Raphaël Barazzutti
Thanks for all your comments :) > > > One more thing : > > > > code like > > > > return ((input.get() & 0xff) << 24) | ((input.get() & > > 0xff) << 16) | ((input.get() & 0xff) << 8) > > | ((input.get() & 0xff)); > > > > where input is a ByteBuffer can be re