Re: Adding a secured() event in the IoHandler

2018-04-13 Thread Emmanuel Lecharny
I get your point. It's possible to add a logger filter more than once in the chain, assuming the name is not the same. I would argue that for any event to start at the Head in order for it to traverse all the filter is a bit spurious: such event is likely not to be process by any filter. I'll

[jira] [Commented] (SSHD-640) Streams are not flushed from SSH Command

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437739#comment-16437739 ] ASF GitHub Bot commented on SSHD-640: - GitHub user gnodet opened a pull request:

[GitHub] mina-sshd pull request #52: [SSHD-640] Streams are not flushed from SSH Comm...

2018-04-13 Thread gnodet
GitHub user gnodet opened a pull request: https://github.com/apache/mina-sshd/pull/52 [SSHD-640] Streams are not flushed from SSH Command You can merge this pull request into a Git repository by running: $ git pull https://github.com/gnodet/mina-sshd SSHD-640 Alternatively

[jira] [Commented] (SSHD-815) Extract SFTP support in its own module

2018-04-13 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437528#comment-16437528 ] Goldstein Lyor commented on SSHD-815: - Great idea :) I am 100% for it. I have reviewed the changes in

Fwd: Adding a secured() event in the IoHandler

2018-04-13 Thread Emmanuel Lécharny
Sent to the dev list, where it belongs... Message transféré Subject: Re: Adding a secured() event in the IoHandler To: Emmanuel Lécharny If nextFilter.fire is called within messageReceived then it will send the event to SSL Filter + 1; if nextFilter.fire

Re: Adding a secured() event in the IoHandler

2018-04-13 Thread Jonathan Valliere
Couple of comments: 1. Any specific reason why you chose “fire” for the base name of the handler function instead of something like “event” ? 2. Instead of calling nextFilter.fire; you might want to call session.getFilterChain().fire() or

[jira] [Commented] (SSHD-721) deadlock: all nio workers wait to be woken up

2018-04-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437302#comment-16437302 ] Jonathan Valliere commented on SSHD-721: {quote} Once all clients with port forwards have killed

[GitHub] mina-sshd pull request #51: [SSHD-815] Extract SFTP in its own module

2018-04-13 Thread gnodet
GitHub user gnodet opened a pull request: https://github.com/apache/mina-sshd/pull/51 [SSHD-815] Extract SFTP in its own module You can merge this pull request into a Git repository by running: $ git pull https://github.com/gnodet/mina-sshd SSHD-815 Alternatively you can

Re: [DISCUSS] Splitting sftp into its own module

2018-04-13 Thread Guillaume Nodet
gnt, that's historical ... https://issues.apache.org/jira/secure/ViewProfile.jspa?name=gnt 2018-04-13 14:15 GMT+02:00 Jonathan Valliere : > Guillaume, what is your handle on JIRA? > > On Fri, Apr 13, 2018 at 7:42 AM, Guillaume Nodet > wrote: > > > I've

[jira] [Comment Edited] (SSHD-721) deadlock: all nio workers wait to be woken up

2018-04-13 Thread Bill Kuker (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437253#comment-16437253 ] Bill Kuker edited comment on SSHD-721 at 4/13/18 12:36 PM: --- You know, as I am

[jira] [Commented] (SSHD-721) deadlock: all nio workers wait to be woken up

2018-04-13 Thread Bill Kuker (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437253#comment-16437253 ] Bill Kuker commented on SSHD-721: - You know, as I am waking up this morning, I do remember noticing that in

[jira] [Comment Edited] (SSHD-721) deadlock: all nio workers wait to be woken up

2018-04-13 Thread Bill Kuker (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437253#comment-16437253 ] Bill Kuker edited comment on SSHD-721 at 4/13/18 12:34 PM: --- You know, as I am

Re: [DISCUSS] Splitting sftp into its own module

2018-04-13 Thread Jonathan Valliere
Guillaume, what is your handle on JIRA? On Fri, Apr 13, 2018 at 7:42 AM, Guillaume Nodet wrote: > I've raised https://issues.apache.org/jira/browse/SSHD-815 and attached a > PR to it. > There may be room for improvement on the sftp client api to make things a > bit easier. >

[jira] [Commented] (SSHD-721) deadlock: all nio workers wait to be woken up

2018-04-13 Thread Bill Kuker (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437233#comment-16437233 ] Bill Kuker commented on SSHD-721: - I am uncertain of the answers to these. My full project includes

Re: [DISCUSS] Splitting sftp into its own module

2018-04-13 Thread Guillaume Nodet
I've raised https://issues.apache.org/jira/browse/SSHD-815 and attached a PR to it. There may be room for improvement on the sftp client api to make things a bit easier. Right now, a user would have to do: SftpClient client = SftpClientFactory.instance().createSftpClient(session) whereas

[jira] [Commented] (SSHD-815) Extract SFTP support in its own module

2018-04-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437214#comment-16437214 ] ASF GitHub Bot commented on SSHD-815: - GitHub user gnodet opened a pull request:

[jira] [Created] (SSHD-815) Extract SFTP support in its own module

2018-04-13 Thread Guillaume Nodet (JIRA)
Guillaume Nodet created SSHD-815: Summary: Extract SFTP support in its own module Key: SSHD-815 URL: https://issues.apache.org/jira/browse/SSHD-815 Project: MINA SSHD Issue Type: New Feature

Re: Adding a secured() event in the IoHandler

2018-04-13 Thread Emmanuel Lécharny
Hi Jonathan, did you had time to review teh diff ? I'd like to push it this week-end if you don't have any remark or comment on it. Many thanks ! Le 09/04/2018 à 17:17, Jonathan Valliere a écrit : > I’d be interested in the diff. Why not propagate the sent down the chain > instead of just to