[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446468#comment-16446468 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 11:04 PM:

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446468#comment-16446468 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 10:59 PM:

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446468#comment-16446468 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 10:46 PM:

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446468#comment-16446468 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 10:45 PM:

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446468#comment-16446468 ] Jonathan Valliere commented on FTPSERVER-485: - OP asked for a secure compare function; bet

MIA for one week !

Hi guys, I'll be MIA for the coming week, starting tomorrow morning. I will left my computer at home during these vacations, so don't expect any code to be committed in the following days. I'll have my phone though, so I will check the mail from time to time, don't worry :-) -- Emmanuel

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446308#comment-16446308 ] Emmanuel Lecharny commented on FTPSERVER-485: - Right, no need to pad, we just need to

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446238#comment-16446238 ] Jonathan Valliere commented on FTPSERVER-485: - {quote} and after this comment I'm going to

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446230#comment-16446230 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 7:14 PM:

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446231#comment-16446231 ] Emmanuel Lecharny commented on FTPSERVER-485: - Last, not least, and after this comment I'm

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446229#comment-16446229 ] Emmanuel Lecharny commented on FTPSERVER-485: - Otherwise, we also may have to check the

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446230#comment-16446230 ] Jonathan Valliere commented on FTPSERVER-485: - Thats why I said that the length comparison

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446066#comment-16446066 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 7:08 PM:

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446221#comment-16446221 ] Emmanuel Lecharny commented on FTPSERVER-485: - No, the modulo won't make a different

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446214#comment-16446214 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 7:03 PM:

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446214#comment-16446214 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 7:03 PM:

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446066#comment-16446066 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 7:01 PM:

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446214#comment-16446214 ] Jonathan Valliere commented on FTPSERVER-485: - On further thought: Using the modulo, an

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446174#comment-16446174 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 6:36 PM:

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446174#comment-16446174 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 6:36 PM:

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446174#comment-16446174 ] Jonathan Valliere commented on FTPSERVER-485: - We can either use the input length as our

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446158#comment-16446158 ] Jonathan Valliere commented on FTPSERVER-485: - Unless I misunderstood the purpose of this

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446110#comment-16446110 ] Emmanuel Lecharny commented on FTPSERVER-485: - Funny enough, before posting my first

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446110#comment-16446110 ] Emmanuel Lecharny edited comment on FTPSERVER-485 at 4/20/18 6:07 PM:

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446105#comment-16446105 ] Emmanuel Lecharny commented on FTPSERVER-485: - If you really want to not leak the password

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446066#comment-16446066 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 5:36 PM:

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446066#comment-16446066 ] Jonathan Valliere commented on FTPSERVER-485: - Haven't tested this yet.  The following

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446040#comment-16446040 ] Jonathan Valliere commented on FTPSERVER-485: - If you return instantly if the lengths do

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446004#comment-16446004 ] Emmanuel Lecharny commented on FTPSERVER-485: - So here, I'm not sure it's needed to add

[jira] [Comment Edited] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445946#comment-16445946 ] Jonathan Valliere edited comment on FTPSERVER-485 at 4/20/18 4:09 PM:

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445946#comment-16445946 ] Jonathan Valliere commented on FTPSERVER-485: - [~elecharny] that is exactly what I was

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445919#comment-16445919 ] Emmanuel Lecharny commented on FTPSERVER-485: - I would say that it does not harm to

[jira] [Commented] (SSHD-812) support asynchronous mode for sftp subsystem

[ https://issues.apache.org/jira/browse/SSHD-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445907#comment-16445907 ] Goldstein Lyor commented on SSHD-812: - Like I said, the failures are intermittent - I will keep an eye

[jira] [Assigned] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere reassigned FTPSERVER-485: --- Assignee: Jonathan Valliere > Timing Side Channel PasswordEncryptor >

[jira] [Commented] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445836#comment-16445836 ] Jonathan Valliere commented on FTPSERVER-485: - Since FTPSERVER is asynchronous by design,

[jira] [Commented] (SSHD-814) enrich the SftpEventListener

[ https://issues.apache.org/jira/browse/SSHD-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445826#comment-16445826 ] Goldstein Lyor commented on SSHD-814: - Specifically about removal, there are a few cases where the

[jira] [Commented] (DIRMINA-1078) OrderedThreadPoolExecutor should allow sessions to be prioritized

[ https://issues.apache.org/jira/browse/DIRMINA-1078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445808#comment-16445808 ] Guus der Kinderen commented on DIRMINA-1078: Apologies for the long wait, gentlemen. I have

[jira] [Commented] (SSHD-814) enrich the SftpEventListener

[ https://issues.apache.org/jira/browse/SSHD-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445768#comment-16445768 ] Goldstein Lyor commented on SSHD-814: - I don't understand the requirements: {quote} When upload/download

[jira] [Updated] (FTPSERVER-485) Timing Side Channel PasswordEncryptor

[ https://issues.apache.org/jira/browse/FTPSERVER-485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yannic Noller updated FTPSERVER-485: Description: Dear Apache FTPServer developers, We have found a timing side-channel in