[
https://issues.apache.org/jira/browse/SSHD-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797783#comment-16797783
]
Subramaniajeeva edited comment on SSHD-907 at 3/21/19 3:30 AM:
---
[~lgoldstein]
I’ll look into not using mark reset there.
On Wed, Mar 20, 2019 at 11:05 AM Emmanuel Lécharny
wrote:
>
> On 20/03/2019 15:30, Jonathan Valliere wrote:
> > The offending code is in AbstractPollingIoProcessor. Are you agreeing
> that
> > AbstractPollingIoProcessor has no place modifying the
On 20/03/2019 15:30, Jonathan Valliere wrote:
The offending code is in AbstractPollingIoProcessor. Are you agreeing that
AbstractPollingIoProcessor has no place modifying the buffer positions?
Removing buf.reset() would probably fix the problem.
The reason we reset the buffer is that we
And all use of mark() should be removed through the entire codebase... but
thats a second step.
On Wed, Mar 20, 2019 at 10:30 AM Jonathan Valliere
wrote:
> The offending code is in AbstractPollingIoProcessor. Are you agreeing
> that AbstractPollingIoProcessor has no place modifying the buffer
The offending code is in AbstractPollingIoProcessor. Are you agreeing that
AbstractPollingIoProcessor has no place modifying the buffer positions?
Removing buf.reset() would probably fix the problem.
(replying to the mailing list)
On 20/03/2019 15:11, Jonathan Valliere wrote:
And mina is calling reset() bad combo. Why would mina ever need to
modify the position? Just keep on writing the buffer as-is until flushed?
It should. Any filter taking a IoBuffer as an input should *never*
Nothing in Mina should use the mark/reset functionality because it does not
compound and the unknown addition of filters create edge cases where it is
compounded. Should manually grab he position and manually revert the
position when necessary.
On Wed, Mar 20, 2019 at 4:23 AM Greg Thomas wrote:
bangnab opened a new pull request #97: Catch NumberFormatException when parsing
versions
URL: https://github.com/apache/mina-sshd/pull/97
This is necessary to be able to cope with the reported versions of
SSH-2.0-VShell_4_2_1_1051 VShell:
Many thanks!
Greg
> On 20 Mar 2019, at 07:42, Emmanuel Lécharny wrote:
>
> I can reproduce the issue with a much simpler application (using the 'chat'
> example).
>
> I will try to get a fix asap.
>
>
>> On 19/03/2019 23:33, Emmanuel Lécharny wrote:
>> Ok, looking at the CompressionFilter,
I can reproduce the issue with a much simpler application (using the
'chat' example).
I will try to get a fix asap.
On 19/03/2019 23:33, Emmanuel Lécharny wrote:
Ok, looking at the CompressionFilter, here is what I see:
@Override
protected Object doFilterWrite(NextFilter
[
https://issues.apache.org/jira/browse/SSHD-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796832#comment-16796832
]
Subramaniajeeva commented on SSHD-907:
--
Monitored for 25 hours. No issues so far. Thanks for the fix.
[
https://issues.apache.org/jira/browse/SSHD-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796835#comment-16796835
]
Subramaniajeeva commented on SSHD-907:
--
Just noticed that there is one more issue where the username
12 matches
Mail list logo
