[jira] [Created] (SSHD-918) Implement UMAC message authentication code

2019-05-13 Thread Goldstein Lyor (JIRA)
Goldstein Lyor created SSHD-918: --- Summary: Implement UMAC message authentication code Key: SSHD-918 URL: https://issues.apache.org/jira/browse/SSHD-918 Project: MINA SSHD Issue Type:

[jira] [Commented] (SSHD-916) Followup of SSHD-912 Review usages of AbstractCloseable#lock and constrain them only to actually needed ones

2019-05-13 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839071#comment-16839071 ] Goldstein Lyor commented on SSHD-916: - Please try https://github.com/lgoldstein/mina-sshd/tree/SSHD-916

[jira] [Created] (SSHD-917) Add support for SSH2 public/private key fiels

2019-05-13 Thread Goldstein Lyor (JIRA)
Goldstein Lyor created SSHD-917: --- Summary: Add support for SSH2 public/private key fiels Key: SSHD-917 URL: https://issues.apache.org/jira/browse/SSHD-917 Project: MINA SSHD Issue Type:

[jira] [Assigned] (SSHD-916) Followup of SSHD-912 Review usages of AbstractCloseable#lock and constrain them only to actually needed ones

2019-05-13 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor reassigned SSHD-916: --- Assignee: Goldstein Lyor > Followup of SSHD-912 Review usages of AbstractCloseable#lock and

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838939#comment-16838939 ] Emmanuel Lecharny commented on DIRMINA-1107: https://tools.ietf.org/html/rfcThe big problem

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838924#comment-16838924 ] Jonathan Valliere commented on DIRMINA-1107: I thought there were other commands in TLS

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838921#comment-16838921 ] Emmanuel Lecharny commented on DIRMINA-1107: Key renegotiation (which has been removed in

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838919#comment-16838919 ] Jonathan Valliere commented on DIRMINA-1107: [~elecharny] TLS key renegotiation and other

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838918#comment-16838918 ] Emmanuel Lecharny commented on DIRMINA-1107: @Jonathan what for ? Once the HS is completed,

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838914#comment-16838914 ] Emmanuel Lecharny commented on DIRMINA-1107: Regarding the multi-threading aspect: *

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838907#comment-16838907 ] Jonathan Valliere commented on DIRMINA-1107: Every time you receive a message you have to

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838898#comment-16838898 ] Emmanuel Lecharny commented on DIRMINA-1107: There are a few bad things done. In the

[jira] [Commented] (SSHD-916) Followup of SSHD-912 Review usages of AbstractCloseable#lock and constrain them only to actually needed ones

2019-05-13 Thread Goldstein Lyor (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838743#comment-16838743 ] Goldstein Lyor commented on SSHD-916: - Thanks - will look  at it when I get a chance.. > Followup of

[jira] [Comment Edited] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Guus der Kinderen (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838709#comment-16838709 ] Guus der Kinderen edited comment on DIRMINA-1107 at 5/13/19 5:03 PM:

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Guus der Kinderen (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838709#comment-16838709 ] Guus der Kinderen commented on DIRMINA-1107: Thanks for all the feedback! For what it's

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838707#comment-16838707 ] Jonathan Valliere commented on DIRMINA-1107: If the same fix can be applied to both

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838682#comment-16838682 ] Emmanuel Lecharny commented on DIRMINA-1107: I'd rather have this issue cover both

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838675#comment-16838675 ] Jonathan Valliere commented on DIRMINA-1107: I updated the AFFECTS / FIX VERSION, once

[jira] [Updated] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1107: --- Fix Version/s: (was: 2.0.23) > SslHandler flushScheduledEvents race condition,

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838673#comment-16838673 ] Jonathan Valliere commented on DIRMINA-1107: The counter doesn't make any sense since each

[jira] [Updated] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1107: --- Affects Version/s: 2.1.2 > SslHandler flushScheduledEvents race condition, redux >

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838669#comment-16838669 ] Emmanuel Lecharny commented on DIRMINA-1107: The pb is that we have 2 queues, and we have

[jira] [Comment Edited] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Guus der Kinderen (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838662#comment-16838662 ] Guus der Kinderen edited comment on DIRMINA-1107 at 5/13/19 4:15 PM:

[jira] [Comment Edited] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Guus der Kinderen (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838662#comment-16838662 ] Guus der Kinderen edited comment on DIRMINA-1107 at 5/13/19 4:13 PM:

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Guus der Kinderen (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838662#comment-16838662 ] Guus der Kinderen commented on DIRMINA-1107: We've found the issue in version 2.1.2.

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838654#comment-16838654 ] Jonathan Valliere commented on DIRMINA-1107: I'm not exactly sure the real purpose of that

[jira] [Comment Edited] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838647#comment-16838647 ] Emmanuel Lecharny edited comment on DIRMINA-1107 at 5/13/19 3:59 PM:

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Emmanuel Lecharny (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838647#comment-16838647 ] Emmanuel Lecharny commented on DIRMINA-1107: Seems like we should include the counter into

[jira] [Commented] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838625#comment-16838625 ] Jonathan Valliere commented on DIRMINA-1107: What version does this apply to? > SslHandler

[jira] [Updated] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Jonathan Valliere (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Valliere updated DIRMINA-1107: --- Fix Version/s: 2.0.23 2.1.3 > SslHandler flushScheduledEvents

[jira] [Created] (DIRMINA-1107) SslHandler flushScheduledEvents race condition, redux

2019-05-13 Thread Guus der Kinderen (JIRA)
Guus der Kinderen created DIRMINA-1107: -- Summary: SslHandler flushScheduledEvents race condition, redux Key: DIRMINA-1107 URL: https://issues.apache.org/jira/browse/DIRMINA-1107 Project: MINA

[jira] [Updated] (SSHD-916) Followup of SSHD-912 Review usages of AbstractCloseable#lock and constrain them only to actually needed ones

2019-05-13 Thread Roberto Deandrea (JIRA)
[ https://issues.apache.org/jira/browse/SSHD-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roberto Deandrea updated SSHD-916: -- Summary: Followup of SSHD-912 Review usages of AbstractCloseable#lock and constrain them only to